Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule: ARIA required context role (ff89c9) #255
Rule: ARIA required context role (ff89c9) #255
Changes from 61 commits
4b2cd9a
bdbfbeb
f80607d
409bb9a
8f79ac6
4f4701d
7b43dde
2ac617f
ded2be6
8a81b50
1542f48
b9b79a8
8bf6038
dfc56b2
c2ccbc1
35d480e
9835b44
d92d89c
16f50c7
47e4ce5
96472af
0785f09
9c81dcd
52a4b1e
4339973
5c7b137
127beb4
473016f
b952555
dc50845
542090d
31a7bf1
576eb0d
c031c89
8d08752
08069fa
7578413
b360785
4b13b65
922d3e8
33d0f44
e9f8a8a
1a6d693
9a6da41
6839767
376ce5f
9b73e57
87777d3
476a2e6
4ff8e00
b7e25e0
c41e314
78169f8
ee977ac
c41dfe3
8f62229
32b92de
07ba91a
191b5cc
c4e760e
f152e32
8262e3a
4efedba
1af2679
45f5648
ca84d89
89aee3c
f4f5188
5b45798
e3db62e
5cbc373
7362c00
5db02eb
b8519e1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"is diverging from" -> "is different than"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rephrase this. You're essentially saying that elements own each other. That's not right. I would say replace "recognise which elements are owned by each other" with "consistently identify which element [owns] which other element."
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you have this not fail SC 1.3.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally the file name should be
owned-by.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This contradicts your point 1 and 2. I also don't think this is intuitive, and it doesn't seem to be how it is currently implemented. I would guess this is unlikely to ever become standardised.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WilcoFiers,
This part of your comment:
... is that for the note or for the entire definition of "owned by"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Owned by" definition has been slightly rewritten and note removed.
Can I have you review again and say if you agree?