Don't copy strings when reading them in

actgardner · Oct 11, 2021 · 568c540 · 568c540
1 parent f71f636
commit 568c540
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/v9/vm/reader_test.go b/v9/vm/reader_test.go
@@ -6,8 +6,9 @@ import (
 )
 
 func BenchmarkReadBool(b *testing.B) {
+	buf := make([]byte, 8)
 	for i := 0; i < b.N; i++ {
 		r := bytes.NewBuffer([]byte{1})
-		readBool(r)
+		readBool(r, buf)
 	}
 }
diff --git a/v9/vm/readers.go b/v9/vm/readers.go
@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"io"
 	"math"
+	"unsafe"
 )
 
 type ByteReader interface {
@@ -153,7 +154,7 @@ func readString(r io.Reader, buf []byte) (string, error) {
 	if err != nil {
 		return "", err
 	}
-	return string(bb), nil
+	return *(*string)(unsafe.Pointer(&bb)), nil
 }
 
 func readFixed(r io.Reader, size int) ([]byte, error) {