Enable Fully Qualified Enum Names #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasleung
commented
Aug 4, 2021
| @@ -50,7 +50,7 @@ func (e *EnumDefinition) SymbolName(symbol string) string { | |||
| } | |||
|
|
|||
| func (e *EnumDefinition) GoType() string { | |||
| return generator.ToPublicName(e.name.Name) | |||
| return generator.ToPublicName(e.name.String()) | |||
There was a problem hiding this comment.
@actgardner unsure if this was intentionally using .Name instead of .String() 😅
None of the existing tests broke when I made this change so I suspect this is not impactful though would appreciate some additional context around this 👍
|
Hey @lukasleung! Sorry for the slow response - this looks like the right behaviour. Because it changes the generated code I'll need to bump the major version to release it. Thanks for your contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #169.
What has Changed
GoType()for theEnumDefinitionto useString()which will format properly instead ofNamev9/test.shalso runs ago get -t -v -u ./...which updated dependenciesgo mod tidy