Simplify union codegen #196
Conversation
Don't generate union classes when a simple union contains only two elements, one of which is null. Instead, generate pointers to the types. (Golang built-in nullability) actgardner#184
|
@actgardner Here is my first attempt at addressing the issue... any feedback is most welcome! Hopefully this is a good first step towards a releasable feature/improvement. N.B. In order to preserve the GenericRecord behaviour and keep its tests from failing I did need to add a |
|
Hi @actgardner @frankgrimes97, Initially I stumbled on this related but closed issue #40. Thank you! Regards Tomas. |
|
Hi @actgardner, any update on this PR? As Tomas stated, this would be highly beneficial. Thanks! |
|
Hello @actgardner, I also would find this a great improvement to the code generation. |
|
Hi @actgardner, is this feature a possibility in the future? |
Don't generate union classes when a simple union contains only
two elements, one of which is null.
Instead, generate pointers to the types. (Golang built-in nullability)
#184