Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for importer: parameters resample and resolution #349

Merged
merged 4 commits into from
May 27, 2022
Merged

Tests for importer: parameters resample and resolution #349

merged 4 commits into from
May 27, 2022

Conversation

juleshaas
Copy link
Member

@juleshaas juleshaas commented May 6, 2022 •
edited
Loading

PR

  • adds test for the parameters resample and resolution of the raster importer
  • does some linting in the process chains
  • fixes some typos

solves #328

@juleshaas juleshaas self-assigned this May 6, 2022
@juleshaas juleshaas marked this pull request as ready for review May 24, 2022 09:03
@juleshaas juleshaas requested a review from anikaweinmann May 24, 2022 13:50
anikaweinmann
anikaweinmann approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@anikaweinmann anikaweinmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks very good :)

@juleshaas juleshaas merged commit 7422501 into main May 27, 2022
@juleshaas juleshaas deleted the importer_test branch May 27, 2022 07:14
@juleshaas juleshaas mentioned this pull request Jul 21, 2022
Closed
@mmacata mmacata added this to the 4.1.0 milestone Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anikaweinmann anikaweinmann anikaweinmann approved these changes

Assignees

@juleshaas juleshaas

Labels
None yet
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@juleshaas @anikaweinmann @mmacata