Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to use keycloak authentication token #381

Merged
merged 22 commits into from
Nov 30, 2022
Merged

Conversation

anikaweinmann
Copy link
Member

This merge requests allows to use a keycloak token for authentication, where the user attributes, role and group have to be included.

The changes includes:

  • creation of a ActiniaUserBase where the original ActiniaUser inherit from
  • Adding a new ActiniaKeycloakUser class which is used when it is configured in the config file via:

If the keycloak authentication token is configured the basic authenication will not work at the same time.

@anikaweinmann anikaweinmann marked this pull request as ready for review October 6, 2022 05:41
Copy link
Member

@mmacata mmacata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you for this long-awaited feature 👯‍♀️ 🎉

Besides some small typos I have some comments, none of them are really blocking, but I would like to know your opinion about them.

src/actinia_core/core/common/keycloak_user.py Outdated Show resolved Hide resolved
src/actinia_core/core/common/keycloak_user.py Outdated Show resolved Hide resolved
src/actinia_core/core/common/user_base.py Outdated Show resolved Hide resolved
tests/unittests/test_keycloak_user.py Outdated Show resolved Hide resolved
tests/unittests/test_keycloak_user.py Outdated Show resolved Hide resolved
src/actinia_core/core/common/keycloak_user.py Show resolved Hide resolved
src/actinia_core/core/common/user.py Show resolved Hide resolved
src/actinia_core/core/common/config.py Outdated Show resolved Hide resolved
src/actinia_core/core/common/config.py Outdated Show resolved Hide resolved
src/actinia_core/core/common/keycloak_user.py Outdated Show resolved Hide resolved
@neteler neteler added this to the next_minor milestone Nov 8, 2022
@anikaweinmann anikaweinmann merged commit d1e46ce into main Nov 30, 2022
@mmacata
Copy link
Member

mmacata commented Nov 30, 2022

💃

@anikaweinmann anikaweinmann modified the milestones: next_minor, 4.5.0 Dec 14, 2022
@mmacata mmacata deleted the keycloak2 branch August 15, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants