Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix version to not be dirty after release #59

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

mmacata
Copy link
Member

@mmacata mmacata commented Oct 31, 2019

This PR is a follow up to #57. Instead of the version shown there, after a clean release it is shown like this:

{
  "plugins": "actinia_statistic_plugin", 
  "version": "0.99.0+ga8ff003.dirty"
}

This "not clean" part are files which are not copied into the docker but commited (some docker files not relevant for the main build, ...)
This PR suggests to conduct a git pull to make the version clean again.

Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I cannot judge all implications (so, a +0.5 ;-) from my side )

@mmacata
Copy link
Member Author

mmacata commented Oct 31, 2019

Ok, then I'll merge now

@mmacata mmacata merged commit 04e4f39 into actinia-org:master Oct 31, 2019
@mmacata mmacata deleted the version+docker branch October 31, 2019 14:43
@mmacata mmacata added this to the 0.99.X milestone Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants