Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start with parallel processing #1

Merged
merged 47 commits into from
Oct 6, 2022
Merged

Conversation

anikaweinmann
Copy link
Member

@anikaweinmann anikaweinmann commented May 25, 2022

  • Parallel Ephemeral Processing
    • Importer
    • Stdout

TODO in other PR:

  • Parallel Persistent Processing
  • Parallel Ephemeral Processing - Exporter
  • Parallel Ephemeral Processing - reuse of exporter in next PC

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@anikaweinmann anikaweinmann marked this pull request as ready for review June 2, 2022 19:21
Copy link
Member

@mmacata mmacata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks a lot!
I made some review comments and additionally some general thoughts:

  • for the database table fields and models, some attributes might not be needed
  • It would be great to get rid off all Regeldatei / Rulefile occurances, as this schema is not used here
  • Please re-check the copyright notes. I found Copyright (c) 2018-present at least once and also inconsistencies between the two header years
  • I like the endpoint /api/v3/locations/nc_spm_08_grass7_root/processing_parallel but I am not so sure about the "general" ones with /api/v3/processing_parallel/batchjobs/1 and /api/v3/processing_parallel/jobs/1. It might be a bit confusing as usually the jobs can be found at the according ressource within actinia-core. I would like to discuss some alternatives here, maybe next week in person ;)

README.md Outdated Show resolved Hide resolved
docker/actinia-parallel-plugin-test/Dockerfile Outdated Show resolved Hide resolved
docker/docker-compose.yml Show resolved Hide resolved
src/actinia_parallel_plugin/apidocs/jobs.py Outdated Show resolved Hide resolved
src/actinia_parallel_plugin/apidocs/jobs.py Outdated Show resolved Hide resolved
src/actinia_parallel_plugin/model/batch.py Outdated Show resolved Hide resolved
src/actinia_parallel_plugin/model/batch.py Outdated Show resolved Hide resolved
src/actinia_parallel_plugin/model/batch_process_chain.py Outdated Show resolved Hide resolved
src/actinia_parallel_plugin/model/jobtabelle.py Outdated Show resolved Hide resolved
src/actinia_parallel_plugin/model/response_models.py Outdated Show resolved Hide resolved
@anikaweinmann
Copy link
Member Author

  • I like the endpoint /api/v3/locations/nc_spm_08_grass7_root/processing_parallel but I am not so sure about the "general" ones with /api/v3/processing_parallel/batchjobs/1 and /api/v3/processing_parallel/jobs/1. It might be a bit confusing as usually the jobs can be found at the according ressource within actinia-core. I would like to discuss some alternatives here, maybe next week in person ;)
  • /api/v3/resouces/USERID/batches/1 (Only users who are in the group that created the job are allowed to query it!)

  • /api/v3/resouces/USERID/batches/1/jobs/1 (Only users who are in the group that created the job are allowed to query it!)

  • /api/v3/resouces/USERID/jobs/resource_id_without_"resource_id"

    • Equal to /api/v3/resouces/USERID/resource_id_with_"resource_id" (will be done later in actinia_core)
    • for iterations all are returned
    • /api/v3/resouces/USERID/jobs/resource_id_without_"resource_id"/iterations"/ITERATION_NUMBER returns only one iteration
    • /api/v3/resouces/USERID/jobs/resource_id_without_"resource_id"/iterations/latest returns only the last iteration

@anikaweinmann
Copy link
Member Author

@mmacata the endpoints are changed as discussed, please review again.
Dependencies are added to README in actinia-org/actinia-core#356

@anikaweinmann anikaweinmann requested a review from mmacata July 4, 2022 08:27
Copy link
Member

@mmacata mmacata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Great :)

@anikaweinmann anikaweinmann merged commit af462cd into main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants