-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start with parallel processing #1
Conversation
…icht erkannt in r.mapcalc)
…st block is not started
Co-authored-by: Markus Neteler <neteler@osgeo.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks a lot!
I made some review comments and additionally some general thoughts:
- for the database table fields and models, some attributes might not be needed
- It would be great to get rid off all
Regeldatei
/Rulefile
occurances, as this schema is not used here - Please re-check the copyright notes. I found
Copyright (c) 2018-present
at least once and also inconsistencies between the two header years - I like the endpoint
/api/v3/locations/nc_spm_08_grass7_root/processing_parallel
but I am not so sure about the "general" ones with/api/v3/processing_parallel/batchjobs/1
and/api/v3/processing_parallel/jobs/1
. It might be a bit confusing as usually the jobs can be found at the according ressource within actinia-core. I would like to discuss some alternatives here, maybe next week in person ;)
|
@mmacata the endpoints are changed as discussed, please review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Great :)
TODO in other PR: