ci: multiple ubuntu version

[toast-gear]

Depends on #1924 being merged

Notes

• @mumoshu The only functional change here is removal of the latest tag which is replaced by the OS version -latest e.g. ubuntu-20.04-latest. We should stop using latest with the OS going forward even when we eventually stop producing a 20.04 image (like we did with the 18.04 image) and only have 1 runner image. We'll ultimately have to produce another ubuntu image down the road so we should abandoned using a naked latest tag.

Build produces the below tags:

https://github.com/actions-runner-controller/actions-runner-controller/actions/runs/3553366494/jobs/5968874974

I think they all line up with what we do now https://hub.docker.com/r/summerwind/actions-runner/tags

[mumoshu]

Suggested change

	${{ env.DOCKERHUB_USERNAME }}/${{ matrix.name }}:${{ matrix.os-name }}-${{ matrix.os-version }}-latest
	${{ env.DOCKERHUB_USERNAME }}/${{ matrix.name }}:${{ matrix.os-name }}-${{ matrix.os-version }}

This looks geat overall! Thanks for your efforts. One suggestion for this though- Can we omit the "-latest" suffix for this variant? I think we are basically omitting that suffix also on the existing v${{ env.RUNNER_VERSION }}-${{ matrix.os-name }}-${{ matrix.os-version }} image.

[toast-gear]

We are that's true. Now you've pointed it out it's a bit annoying but I think we probably should stick with not having it for backwards compatibility reasons.

[mumoshu]

I believe it's not easy, but can we add another pipeline to keep publishing latest, that points to the latest ubuntu 20.04 image for a while and will eventually get updated to 22.04 in the near future?

Without that another pipeline, we end up immediately stopping updates to the latest image, which many folks seem to be using today, and those folks would end up seeing a lot of runner auto updates triggered before their runners within runner pods get up and running, which will trigger a storm of questions and bug reports...

[mumoshu]

will eventually get updated to 22.04 in the near future?

Or maybe we can deprecate the latest tag soon and stop updating it e.g. 1 month before we stop publishing legacy 20.04 images.
The result might be the same. I think stopping updates on the latest tag immediately can be a source of confusion and breakage though.

[toast-gear]

Having had a think I agree with all this. I think we should deprecate the latest tag entirely but yeh, we probably should do it after 22.04 has been out for some time.

Perhaps we can update the startup.sh to spit out some warnings too and pin an issue to give people the best chance of seeing it before we stop updating it? Should we look to delete the latest tag from DockerHub entirely too as it'll be very misleading if the tag left hanging around once we have stopped using it.

[mumoshu]

LGTM. Thank you so much for your contribution as always!