Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ubuntu 22.04 image with openssh #2098

Conversation

arielly-parussulo
Copy link
Contributor

Add Openssh client to ubuntu 22.04 runner.

@mumoshu
Copy link
Collaborator

mumoshu commented Dec 16, 2022

@arielly-parussulo Hey! Thanks for submitting this. Our plan for 22.04 runner images is to make those dead simple, including only minimum dependencies that are needed in every environment. I think ssh client is needed only when you ssh from the runner into other nodes or whatever running sshd, or cloning private Git repositories via ssh in case https auth isn't possible. Did I get it correctly?

@toast-gear Please correct me if I missed anything!

@arielly-parussulo
Copy link
Contributor Author

@arielly-parussulo Hey! Thanks for submitting this. Our plan for 22.04 runner images is to make those dead simple, including only minimum dependencies that are needed in every environment. I think ssh client is needed only when you ssh from the runner into other nodes or whatever running sshd, or cloning private Git repositories via ssh in case https auth isn't possible. Did I get it correctly?

@toast-gear Please correct me if I missed anything!

No problem! I did this Pull Request because some of the developers of my company are doing a git clone operation with SSH. I will roll back to the Ubuntu 20 runner for now and check with my team whether is possible or them to use HTTPS to clone their repositories.
Thanks for the reply!

@mumoshu
Copy link
Collaborator

mumoshu commented Dec 19, 2022

@arielly-parussulo Thanks for your response and feedback! We're still figuring out what to be included in the 22.04 runner image. We're are to include anything that can be considered "core" and perhaps ssh might be too "core" to be stripped. Please don't hesitate to share your team's feedback to us so that we can reconsider with more confidence!

@Link- Link- mentioned this pull request Jan 18, 2023
7 tasks
@asardaes
Copy link

@mumoshu May I ask if the discussion about "core" dependencies to include was finalized? My team also uses SSH to create commits in a repository different than the one that triggers the workflow. I imagine there are alternatives for us, but it would be good to first know what your team decided.

@mumoshu
Copy link
Collaborator

mumoshu commented Aug 21, 2023

@asardaes Hey! We might have two channels of runner images. First, the GH official runner images would be minimal (See https://github.com/actions/runner/blob/main/images/Dockerfile). I don't expect those to have dependencies like ssh included.

Second, we might provide "community" runner images with different flavors. What if we had:

  • Base runner images: including so-called "common" dependencies like ssh
  • AWS runner images: including awscli
  • GCP runner images: including google cloud-sdk
  • ...

@asardaes
Copy link

But then that's still under discussion, right? Is there a place where that's tracked?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants