Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to support ghes alpha release #199

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Conversation

ericsciple
Copy link
Contributor

@ericsciple ericsciple commented Mar 25, 2020

For GHES alpha release, leverage GITHUB_URL to determine clone URL (may change post alpha)

@@ -1266,6 +1266,46 @@ const windowsRelease = release => {
module.exports = windowsRelease;


/***/ }),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore index.js

src/git-auth-helper.ts Outdated Show resolved Hide resolved
return `${serviceUrl.origin}/${encodedOwner}/${encodedName}`
}

export function getServerUrl(): URL {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: move this so it's next to getApiUrl()?

@ericsciple ericsciple merged commit 85b1f35 into master Mar 25, 2020
@ericsciple ericsciple deleted the users/ericsciple/m168alpha branch March 25, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants