Include common example for fetching PR base-ref #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this seems to be a common scenario and is generating a lot of discussion (actions#93), it seems worthwhile to add it to the readme as an example. I placed it before the other fetch examples because this use-case still only fetches minimal history (only adding one additional ref); so it seems helpful to place this above the other fetch examples which all do deeper fetches.
|
I haven't verified the table-of-contents link (I typed it by hand) |
jasonkarns
commented
Apr 9, 2020
| ```yml | ||
| - uses: actions/checkout@v2 | ||
| - name: Fetch base_ref HEAD | ||
| run: git fetch --depth=1 origin +refs/heads/${{github.base_ref}}:refs/remotes/origin/${{github.base_ref}} |
There was a problem hiding this comment.
I think this could actually be simplified to
git fetch --depth=1 origin +${{github.base_ref}}
or
git fetch --depth=1 origin +refs/heads/${{github.base_ref}}
since the destination is the conventional remote ref. But I'm unsure if there are any edge cases with that shortened form that users would encounter... (Then again, since this is supposed to be for "common scenarios", perhaps the short form is better?)
|
@jasonkarns thanks will look over this soon! |
egpbos
added a commit
to roofit-dev/root
that referenced
this pull request
Jun 24, 2021
Uses example in as of yet unmerged PR actions/checkout#213
radum
added a commit
to radum/lighthouse-ci
that referenced
this pull request
Jun 30, 2021
When running LHCI in GH Actions due to how checkout action clones the repo with a fetch depth of 1 by default the base branch might be missing so LH will not be able to find it during health check. Changing the action settings and fetching the base using a new step will fix this problem for almost all cases where the repo is big enough. This has been discussed here actions/checkout#93 and here actions/checkout#213
Axel-Naumann
pushed a commit
to root-project/root
that referenced
this pull request
Oct 29, 2021
Uses example in as of yet unmerged PR actions/checkout#213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this seems to be a common scenario and is generating a lot of discussion (#93), it seems worthwhile to add it to the readme as an example.
I placed it before the other fetch examples because this use-case still only fetches minimal history (only adding one additional ref); so it seems helpful to place this above the other fetch examples which all do deeper fetches.