Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dr Snaps launch PR #556

Merged
merged 27 commits into from
Sep 7, 2023
Merged

Dr Snaps launch PR #556

merged 27 commits into from
Sep 7, 2023

Conversation

juxtin
Copy link
Contributor

@juxtin juxtin commented Aug 31, 2023 •
edited
Loading

This PR includes the following prerequisites for the Dr Snaps launch:

  • the retry-on-snapshot-warnings and retry-on-snapshot-warnings-timeout config options, courtesy of @hmaurer
  • the removal of filtering snapshot warnings, brought in from Show all non-empty snapshot warnings #452.
  • setting retry-on-snapshot-warnings to false by default.
  • adding a link to the (forthcoming) docs when displaying snapshot warnings.

@juxtin juxtin requested a review from a team as a code owner August 31, 2023 23:17
@jhutchings1
Copy link
Contributor

Dr Snaps sounds like a cool cartoon doctor.

Also, thanks for pulling all this together @juxtin! ✨

juxtin
juxtin commented Sep 6, 2023
View reviewed changes
src/dependency-graph.ts Outdated Show resolved Hide resolved
febuiles and others added 2 commits September 7, 2023 07:08
@febuiles @juxtin
Update src/dependency-graph.ts
7d0e0f6 
Co-authored-by: Justin Holguín <juxtin@github.com>
@febuiles
add dist
5e4b90e
febuiles
febuiles reviewed Sep 7, 2023
View reviewed changes
action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
febuiles
febuiles reviewed Sep 7, 2023
View reviewed changes
src/main.ts
retryUntil: number
retryDelay: number
}
): ReturnType<typeof dependencyGraph.compare> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Q) why do we do this instead of specifying an explicit type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that it's because this is just a wrapper function, so passing through the type as well as the value could simplify things when refactoring.

febuiles
febuiles approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@febuiles febuiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once we've clarified what the default value should be in action.yml I think we're good to go.

@juxtin juxtin merged commit e4d20ce into main Sep 7, 2023
@juxtin juxtin deleted the juxtin/dr-snaps-pre-launch branch September 7, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@febuiles febuiles febuiles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juxtin @jhutchings1 @febuiles @hmaurer