Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout not actually effective #157

Closed
Nailington opened this issue Apr 18, 2023 · 2 comments
Closed

Timeout not actually effective #157

Nailington opened this issue Apr 18, 2023 · 2 comments
Assignees
@JamesMGreene
Labels
wontfix This will not be worked on

Comments

@Nailington
Copy link

I have a GHAction that I have set up to deploy a repo of mine. I was hitting the timeout limit of the Deploy-Pages step of the action. After looking here, I noticed a timeout input. I have since updated the timeout parameter to reflect a MUCH longer time than 10 minutes (I have it set for 7 Days, though I do not expect to reach that at all, nor have I set anything up to pass my token after 24 hours anyway, which would be a limiting factor anyway). While this addition to my workflow has allowed the step to not timeout, the deployment essentially freezes now.

Tue, 18 Apr 2023 02:31:40 GMT
Run actions/deploy-pages@v1
Tue, 18 Apr [2](https://github.com/Math-Study-Dev/nds-host/actions/runs/4725994966/jobs/8385073658#step:4:2)023 02:31:40 GMT
  with:
Tue, 18 Apr 2023 02:31:40 GMT
    timeout: 604800000
Tue, 18 Apr 202[3](https://github.com/Math-Study-Dev/nds-host/actions/runs/4725994966/jobs/8385073658#step:4:3) 02:31:40 GMT
    emit_telemetry: false
Tue, 18 Apr 2023 02:31:40 GMT
    token: ***
Tue, 18 Apr 2023 02:31:[4](https://github.com/Math-Study-Dev/nds-host/actions/runs/4725994966/jobs/8385073658#step:4:4)0 GMT
    error_count: 10
Tue, 18 Apr 2023 02:31:40 GMT
    reporting_interval: [5](https://github.com/Math-Study-Dev/nds-host/actions/runs/4725994966/jobs/8385073658#step:4:5)000
Tue, 18 Apr 2023 02:31:40 GMT
    artifact_name: github-pages
Tue, 18 Apr 2023 02:31:40 GMT
    preview: false
Tue, 18 Apr 2023 02:31:40 GMT
  env:
Tue, 18 Apr 2023 02:31:40 GMT
    GITHUB_PAGES: true
Tue, 18 Apr 2023 02:31:40 GMT
  
Tue, 18 Apr 2023 02:31:42 GMT
Artifact exchange URL: https://pipelines.actions.githubusercontent.com/X0secSu0E2WRKkcQRKUcQDCKkC7bFSTPGfo2rc9fDEKR2jvPE8/_apis/pipelines/workflows/47259949[6](https://github.com/Math-Study-Dev/nds-host/actions/runs/4725994966/jobs/8385073658#step:4:6)6/artifacts?api-version=6.0-preview
Tue, 18 Apr 2023 02:31:42 GMT
Creating Pages deployment with payload:
Tue, 18 Apr 2023 02:31:42 GMT
{
Tue, 18 Apr 2023 02:31:42 GMT
	"artifact_url": "https://pipelines.actions.githubusercontent.com/X0secSu0E2WRKkcQRKUcQDCKkC[7](https://github.com/Math-Study-Dev/nds-host/actions/runs/4725994966/jobs/8385073658#step:4:7)bFSTPGfo2rc9fDEKR2jvPE[8](https://github.com/Math-Study-Dev/nds-host/actions/runs/4725994966/jobs/8385073658#step:4:8)/_apis/pipelines/1/runs/23/artifacts?artifactName=github-pages&%24expand=SignedContent",
Tue, 18 Apr 2023 02:31:42 GMT
	"pages_build_version": "f0ff327717f4755[9](https://github.com/Math-Study-Dev/nds-host/actions/runs/4725994966/jobs/8385073658#step:4:9)623[10](https://github.com/Math-Study-Dev/nds-host/actions/runs/4725994966/jobs/8385073658#step:4:10)fa7847d8d6bd26b296a",
Tue, 18 Apr 2023 02:31:42 GMT
	"oidc_token": "***"
Tue, 18 Apr 2023 02:31:42 GMT
}
Tue, 18 Apr 2023 02:31:42 GMT
Created deployment for f0ff327717f4755962310fa7847d8d6bd26b296a, ID: f0ff327717f4755962310fa7847d8d6bd26b296a
Tue, 18 Apr 2023 02:31:46 GMT
Getting Pages deployment status...
Tue, 18 Apr 2023 02:31:46 GMT
Current status: deployment_in_progress
Tue, 18 Apr 2023 02:31:51 GMT
Getting Pages deployment status...
Tue, 18 Apr 2023 02:31:51 GMT
Current status: deployment_in_progress
Tue, 18 Apr 2023 02:31:56 GMT
Getting Pages deployment status...
Tue, 18 Apr 2023 02:31:57 GMT
Current status: deployment_in_progress
Tue, 18 Apr 2023 02:32:02 GMT
Getting Pages deployment status...
Tue, 18 Apr 2023 02:32:02 GMT
Current status: deployment_in_progress
Tue, 18 Apr 2023 02:32:07 GMT
Getting Pages deployment status...
Tue, 18 Apr 2023 02:32:07 GMT
Current status: deployment_in_progress
[...]
Tue, 18 Apr 2023 02:41:28 GMT
Current status: deployment_in_progress
Tue, 18 Apr 2023 02:41:33 GMT
Getting Pages deployment status...
Tue, 18 Apr 2023 02:41:33 GMT
Current status: deployment_in_progress
Tue, 18 Apr 2023 02:41:38 GMT
Getting Pages deployment status...
Tue, 18 Apr 2023 02:41:39 GMT
Current status: deployment_in_progress
Tue, 18 Apr 2023 02:41:44 GMT
Getting Pages deployment status...
Tue, 18 Apr 2023 02:41:44 GMT
Current status: 
Tue, 18 Apr 2023 02:41:49 GMT
Getting Pages deployment status...
Tue, 18 Apr 2023 02:41:49 GMT
Current status: 
Tue, 18 Apr 2023 02:41:54 GMT
Getting Pages deployment status...
Tue, 18 Apr 2023 02:41:54 GMT
Current status:

It has now just repeated this, even now

Tue, 18 Apr 2023 09:56:06 GMT
Getting Pages deployment status...
Tue, 18 Apr 2023 09:56:06 GMT
Current status:

The runner is at 9 hours now, doing what seems to be nothing. This is my second attempt, and both times it stalled at 10 minutes in.

Why have the timeout input if it isn't gonna work? Is there something I am missing?
@yoannchaudet
Copy link
Collaborator

It looks like there is a bug we will need to look at.

We enforce and do not document a hard limit on the timeout backend side. Obviously, we would never allow a deployment to proceed for 7days+. The real limit is expressed in minutes.

Tangential to a potential real bug (i.e. the deployment should stop earlier), your issue here is that you are completely outside of our terms of services. You are trying to deploy an artifacts 38GB+ in size.

image

Our limit is 1GB. I suggest you find a different platform for hosting your files (assuming they are legal as well).

@JamesMGreene JamesMGreene added the wontfix This will not be worked on label Apr 30, 2023
@JamesMGreene JamesMGreene self-assigned this Apr 30, 2023
@JamesMGreene
Copy link
Contributor

JamesMGreene commented Apr 30, 2023 •
edited
Loading

Related issue enhancement ideas created:

@JamesMGreene JamesMGreene closed this as not planned Won't fix, can't repro, duplicate, stale Apr 30, 2023
@JamesMGreene JamesMGreene mentioned this issue Apr 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamesMGreene JamesMGreene

Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JamesMGreene @yoannchaudet @Nailington