Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if timeout input parameter value exceeds 10 minutes #165

Closed
3 tasks
JamesMGreene opened this issue Apr 30, 2023 · 0 comments · Fixed by #170
Closed
3 tasks

Warn if timeout input parameter value exceeds 10 minutes #165

JamesMGreene opened this issue Apr 30, 2023 · 0 comments · Fixed by #170
Assignees
Labels
enhancement New feature or request

Comments

@JamesMGreene
Copy link
Contributor

The timeout input parameter is default to 10 minutes:

deploy-pages/action.yml

Lines 12 to 15 in af48cf9

timeout:
description: 'Time in milliseconds after which to timeout and cancel the deployment (default: 10 minutes)'
required: false
default: '600000'

However, that value is actually more than just a default, it is also effectively a maximum as it also has to contend with the Pages deployment service's backend-enforced timeout of 10 minutes.

We should:

  • Input the action.yml description to explain that
  • Warn if that input parameter's value exceeds 10 minutes with an explanatory error message
    • This should probably be upgraded to an outright failure of the action step in a future major version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants