Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Install virtualbox on macOS-11 #4010

Closed
wants to merge 6 commits into from
Closed

[macOS] Install virtualbox on macOS-11 #4010

wants to merge 6 commits into from
+77 −8

Conversation

vsafonkin
Copy link
Contributor

@vsafonkin vsafonkin commented Sep 2, 2021 •
edited
Loading

Description

Installation VirtualBox on macOS-11 via brew.
Added AppleScript to approve VirtualBox developer in security preferences of OS.
Execution of commonutils.sh moved to section before Xcode installation in macOS-11 template, because we need reboot system after VirtualBox installation.

Related issue:

internal #2672

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@vsafonkin vsafonkin changed the title [macos] Install virtualbox on macOS-11 [macOS] Install virtualbox on macOS-11 Sep 2, 2021
@vsafonkin vsafonkin marked this pull request as ready for review September 3, 2021 08:05
maxim-lobanov
maxim-lobanov previously approved these changes Sep 3, 2021
View reviewed changes
al-cheb
al-cheb previously approved these changes Sep 3, 2021
View reviewed changes
dmitry-shibanov
dmitry-shibanov previously approved these changes Sep 3, 2021
View reviewed changes
@miketimofeev miketimofeev mentioned this pull request Sep 10, 2021
Closed
8 tasks
fishilico added a commit to fishilico/selinux that referenced this pull request Sep 25, 2021
@fishilico
GitHub Actions: do not use macOS latest image for now
e71a546 
GitHub is currently migrating its macos-latest runner to macOS 11:
actions/runner-images#4060

Unfortunately, installing VirtualBox and Vagrant on this new version of
macOS is not easy, and the current macos11 runner does not support
running virtual machines using Vagrant. This issue is being fixed on
actions/runner-images#4010 .

Until this Pull Request is merged, use macos10 runner instead of
macos-latest, to continue using Vagrant to run the SELinux testsuite in
a virtual machine.

Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
fishilico added a commit to fishilico/selinux that referenced this pull request Sep 25, 2021
@fishilico
GitHub Actions: do not use macOS latest image for now
da91a58 
GitHub is currently migrating its macos-latest runner to macOS 11:
actions/runner-images#4060

Unfortunately, installing VirtualBox and Vagrant on this new version of
macOS is not easy, and the current macos-11 runner does not support
running virtual machines using Vagrant. This issue is being fixed on
actions/runner-images#4010 .

Until this Pull Request is merged, use macos-10.15 runner instead of
macos-latest, to continue using Vagrant to run the SELinux testsuite in
a virtual machine.

Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
fishilico added a commit to fishilico/selinux that referenced this pull request Sep 27, 2021
@fishilico
GitHub Actions: do not use macOS latest image for now
bd4f450 
GitHub is currently migrating its macos-latest runner to macOS 11:
actions/runner-images#4060

Unfortunately, installing VirtualBox and Vagrant on this new version of
macOS is not easy, and the current macos-11 runner does not support
running virtual machines using Vagrant. This issue is being fixed on
actions/runner-images#4010 .

Until this Pull Request is merged, use macos-10.15 runner instead of
macos-latest, to continue using Vagrant to run the SELinux testsuite in
a virtual machine.

Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
jwcart2 pushed a commit to SELinuxProject/selinux that referenced this pull request Oct 4, 2021
@fishilico @jwcart2
GitHub Actions: do not use macOS latest runner for now
b289125 
GitHub is currently migrating its macos-latest runner to macOS 11:
actions/runner-images#4060

Unfortunately, installing VirtualBox and Vagrant on this new version of
macOS is not easy, and the current macos-11 runner does not support
running virtual machines using Vagrant. This issue is being fixed on
actions/runner-images#4010 .

Until this Pull Request is merged, use macos-10.15 runner instead of
macos-latest, to continue using Vagrant to run the SELinux testsuite in
a virtual machine.

Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
Acked-by: Ondrej Mosnacek <omosnace@redhat.com>
@ericLemanissier ericLemanissier mentioned this pull request Oct 6, 2021
Closed
@ZauberNerd ZauberNerd mentioned this pull request Oct 15, 2021
Merged
ZauberNerd added a commit to xing/act that referenced this pull request Oct 15, 2021
@ZauberNerd @KnisterPeter
chore: revert from macos-11 (latest) to macos-10.15
0638191 
The `macos-latest` image was recently updated to macos 11 which does
not include virtualbox anymore.
This commit pins the previous version macos-10.15 until a more permament
fix can be found.
More information can be found in the discussion of this PR:
nektos#840 (comment)
and in the following issue and PR for the actions/virtual-environments:
actions/runner-images#4060
actions/runner-images#4010

Co-authored-by: Markus Wolf <mail@markus-wolf.de>
@Neilpang
Copy link

Is it possible for this PR to be merged?

@miketimofeev
Copy link
Contributor

@Neilpang unfortunately, no. It's not yet ready

@al-cheb al-cheb closed this Oct 20, 2021
@chkpnt chkpnt mentioned this pull request Oct 20, 2021
Open
@Mizux
Copy link

Mizux commented Oct 25, 2021 •
edited
Loading

Are you aware that some users may use Vagrant/VirtualBox to test FreeBSD built without care of the "screen resolution change" limitation issue ?
-> Why not integrating it as it with a disclaimer about this known issue ? (aka best effort support)

ref: #4060 (comment)

@Neilpang
Copy link

who will need to change screen resolution in a github runner ?

@miketimofeev
Copy link
Contributor

@Neilpang @Mizux some customers use macos runners to run UI tests and they need such an ability.

Mizux added a commit to Mizux/cpu_features that referenced this pull request Oct 26, 2021
@Mizux
ci: Migrate FreeBSD to macos-10.15 virtual env
c0e35dd 
note: In preparation to actions/runner-images#4060
which will drop Vagrant/VirtualBox

ref: actions/runner-images#4010
@Mizux Mizux mentioned this pull request Oct 26, 2021
Merged
gchatelet pushed a commit to google/cpu_features that referenced this pull request Oct 26, 2021
@Mizux
ci: Migrate FreeBSD to macos-10.15 virtual env (#191)
5d871e7 
note: In preparation to actions/runner-images#4060
which will drop Vagrant/VirtualBox

ref: actions/runner-images#4010
taratatach added a commit to cozy-labs/cozy-desktop that referenced this pull request Dec 1, 2021
@taratatach
ci: Switch macOS back to v10.15
a0f3149 
  The `macos-latest` Github Actions virtual environment does not support
  VirtualBox anymore (see
  actions/runner-images#4060 and
  actions/runner-images#4010 for more
  details).

  Since we do need a virtual machine running Linux for the cozy-stack to
  have access to a unix filesystem and mimic our production VFS
  behavior, we have to switch back to using the `macos-10.15` virtual
  environment.

  Apparently Github is looking for a solution to this issue so once they
  do find one, we'll be able to switch again to the `macos-latest`
  environment.
divdavem added a commit to AmadeusITGroup/Assistive-Webdriver that referenced this pull request Dec 7, 2021
@divdavem
Switching the CI build back to macos-10.15
21429d3 
The "macos-11" image which is becoming "macos-latest" does not include virtualbox/vagrant yet.
cf actions/runner-images#4060 and actions/runner-images#4010
@crazy-max crazy-max mentioned this pull request Dec 8, 2021
Merged
This was referenced Dec 11, 2021
Merged
Merged
@StephenWithPH
Copy link

some customers use macos runners to run UI tests and they need such an ability.

I believe it's much better to unblock some VirtualBox users (those who do not need UI tests) than to block 100% of your VirtualBox users.

Are you open to reconsidering the current approach of removing VirtualBox completely?

@mondeja mondeja mentioned this pull request Jan 6, 2022
Merged
WOnder93 added a commit to WOnder93/selinux-testsuite that referenced this pull request Feb 9, 2022
@WOnder93
ci: use macos-10.15 to have working vagrant
23a682f 
See: actions/runner-images#4010

Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
lunkwill42 added a commit to Uninett/navappliance that referenced this pull request Feb 23, 2022
@lunkwill42
Lock build to macOS 10.15
67fc0b4 
The macos-latest label  moved to macOS 11. However, this image from
GitHub doesn't have VirtualBox installed, and it's not clear that this
will ever happen. 10.15 is still supported, though.

These two issues are provided as reference:

- actions/runner-images#4060
- actions/runner-images#4010
apatard added a commit to pycontribs/python-vagrant that referenced this pull request Mar 25, 2022
@apatard
.github/workflows/tox.yml: Switch to macosx 10.15
dc563b1 
Use macos 10.15 since they're with vagrant and virt but
don't use 11 and never due to missing vagrant on them.

Ref:
actions/runner-images#4060
actions/runner-images#4010

Signed-off-by: Arnaud Patard <apatard@hupstream.com>
apatard added a commit to pycontribs/python-vagrant that referenced this pull request Mar 25, 2022
@apatard
.github/workflows/tox.yml: Switch to macosx 10.15
e200f87 
Use macos 10.15 since they're with vagrant and virt but
don't use 11 and never due to missing vagrant on them.

Ref:
actions/runner-images#4060
actions/runner-images#4010

Signed-off-by: Arnaud Patard <apatard@hupstream.com>
divdavem added a commit to divdavem/virtualbox-soap that referenced this pull request Apr 12, 2022
@divdavem
Switching the CI build back to macos-10.15
8533f9d 
The "macos-11" image which is becoming "macos-latest" does not include
virtualbox/vagrant yet.
cf actions/runner-images#4060 and actions/runner-images#4010
divdavem added a commit to attester/virtualbox-soap that referenced this pull request Apr 13, 2022
@divdavem
Switching the CI build back to macos-10.15
5063459 
The "macos-11" image which is becoming "macos-latest" does not include
virtualbox/vagrant yet.
cf actions/runner-images#4060 and actions/runner-images#4010
@mayeut mayeut mentioned this pull request May 21, 2022
Closed
8 tasks
@miketimofeev miketimofeev mentioned this pull request May 23, 2022
Merged
4 tasks
kittydoor added a commit to kittydoor/tpm that referenced this pull request Aug 4, 2022
@kittydoor
macos-latest does not support vagrant
c2b3916 
See: actions/runner-images#4010 (comment)
@timmc-edx timmc-edx mentioned this pull request Aug 5, 2022
Open
taratatach added a commit to cozy-labs/cozy-desktop that referenced this pull request Nov 28, 2022
@taratatach
ci: Upgrade github actions macOS runner
10ba82f 
  The `macos-10.15` runner is depecrated since 5/31/22 and will be
  unsupported by 12/1/22 (see
  actions/runner-images#5583).

  We did not upgrade before because the `macos-11` runner does not
  provide VirtualBox which we need to create an Ext filesystem for
  `cozy-stack` (see
  actions/runner-images#4010 for more details on
  previous attempts to add it to `macos-11`)
  and it was not yet available in the `macos-12` runner.

  It's now available in `macos-12` (see
  actions/runner-images#5594) so we can upgrade
  to `macos-12`.
@taratatach taratatach mentioned this pull request Nov 28, 2022
Merged
5 tasks
taratatach added a commit to cozy-labs/cozy-desktop that referenced this pull request Dec 12, 2022
@taratatach
ci: Upgrade github actions macOS runner
c9f94b1 
  The `macos-10.15` runner is depecrated since 5/31/22 and will be
  unsupported by 12/1/22 (see
  actions/runner-images#5583).

  We did not upgrade before because the `macos-11` runner does not
  provide VirtualBox which we need to create an Ext filesystem for
  `cozy-stack` (see
  actions/runner-images#4010 for more details on
  previous attempts to add it to `macos-11`)
  and it was not yet available in the `macos-12` runner.

  It's now available in `macos-12` (see
  actions/runner-images#5594) so we can upgrade
  to `macos-12`.
taratatach added a commit to cozy-labs/cozy-desktop that referenced this pull request Dec 12, 2022
@taratatach
ci: Upgrade github actions macOS runner (#2271)
da899a2 
The `macos-10.15` runner is deprecated since 5/31/22 and will be
unsupported by 12/1/22 (see
actions/runner-images#5583).

We did not upgrade before because the `macos-11` runner does not
provide VirtualBox which we need to create an Ext filesystem for
`cozy-stack` (see
actions/runner-images#4010 for more details on
previous attempts to add it to `macos-11`)
and it was not yet available in the `macos-12` runner.

It's now available in `macos-12` (see
actions/runner-images#5594) so we can upgrade
to `macos-12`.
chenyt9 pushed a commit to MotorolaMobilityLLC/external-selinux that referenced this pull request Mar 6, 2023
@fishilico @jwcart2
GitHub Actions: do not use macOS latest runner for now
0039368 
GitHub is currently migrating its macos-latest runner to macOS 11:
actions/runner-images#4060

Unfortunately, installing VirtualBox and Vagrant on this new version of
macOS is not easy, and the current macos-11 runner does not support
running virtual machines using Vagrant. This issue is being fixed on
actions/runner-images#4010 .

Until this Pull Request is merged, use macos-10.15 runner instead of
macos-latest, to continue using Vagrant to run the SELinux testsuite in
a virtual machine.

Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
Acked-by: Ondrej Mosnacek <omosnace@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CALISOULB CALISOULB CALISOULB approved these changes

@al-cheb al-cheb al-cheb left review comments

@dmitry-shibanov dmitry-shibanov dmitry-shibanov left review comments

@maxim-lobanov maxim-lobanov maxim-lobanov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@vsafonkin @Neilpang @miketimofeev @al-cheb @Mizux @StephenWithPH @maxim-lobanov @dmitry-shibanov @CALISOULB