Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Update cabal pester test #5121

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

al-cheb
Copy link
Contributor

@al-cheb al-cheb commented Feb 22, 2022

Description

2022-02-22T00:34:39.3388641Z  vhd:   [-] cabal config was modified and exists 166ms (164ms|2ms)
2022-02-22T00:34:39.3399886Z  vhd:    Expected path 'C:\cabal' to exist, but it did not exist.
2022-02-22T00:34:39.3400920Z  vhd:    at $env:CABAL_DIR | Should -Exist, C:\image\Tests\Haskell.Tests.ps1:53
2022-02-22T00:34:39.3405661Z  vhd:    at <ScriptBlock>, C:\image\Tests\Haskell.Tests.ps1:53

https://gitlab.haskell.org/haskell/ghcup-hs/-/commit/2c583bcae9e333693b9bd8fc353bb0dcb2af71df - Fix NoAdjustCabalConfig on windows

Fix:

  • Add test to check cabal folder

Related issue:

#5119

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@al-cheb
Copy link
Contributor Author

al-cheb commented Feb 22, 2022

@hasufell, Could you please review?

miketimofeev
miketimofeev previously approved these changes Feb 22, 2022
@krokofant
Copy link

image
image

Are there different kinds of reviews or is this message just confusing? Since hasufell has reviewed it, why is it still waiting for approving review? 🤔

@miketimofeev
Copy link
Contributor

image image

Are there different kinds of reviews or is this message just confusing? Since hasufell has reviewed it, why is it still waiting for approving review? 🤔

at least one reviewer with write access that's the main difference

@miketimofeev miketimofeev merged commit 55a0721 into actions:main Feb 22, 2022
@al-cheb al-cheb deleted the win-remove-cabal-test branch June 21, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants