Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] add Android NDK 25 #5905

Merged
merged 3 commits into from
Jul 26, 2022
Merged

[Windows] add Android NDK 25 #5905

merged 3 commits into from
Jul 26, 2022

Conversation

yujincheng08
Copy link
Contributor

@yujincheng08 yujincheng08 commented Jul 13, 2022 •
edited
Loading

Description

Update Android NDK to new LTS r25

Related issue: #5930

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@ddobranic
Copy link
Contributor

@yujincheng08 , hi! can you please pull the latest code? we removed default version. thank you!

@yujincheng08 yujincheng08 dismissed a stale review via 445b609 July 22, 2022 13:25
@yujincheng08
Copy link
Contributor Author

@ddobranic Done. Thanks for your reminder.

@ddobranic
Copy link
Contributor

/azp run windows2019, windows2022

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@miketimofeev miketimofeev merged commit 46c1fd7 into actions:main Jul 26, 2022
@yujincheng08 yujincheng08 deleted the win-ndk25 branch July 26, 2022 10:31
Thaddeus555555th
Thaddeus555555th reviewed Aug 1, 2022
View reviewed changes
Copy link

@Thaddeus555555th Thaddeus555555th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thaddeus555555th Thaddeus555555th Thaddeus555555th left review comments

@ddobranic ddobranic ddobranic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yujincheng08 @ddobranic @Thaddeus555555th @miketimofeev