Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Add pkg-config via brew for vcpkg #7125

Merged
merged 1 commit into from
Feb 19, 2023
Merged

[macOS] Add pkg-config via brew for vcpkg #7125

merged 1 commit into from
Feb 19, 2023

Conversation

erik-bershel
Copy link
Contributor

Description

Due to vcpkg test failure

Related issue:

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@ChrisThrasher
Copy link

https://github.com/ChrisThrasher/argon/actions/runs/4197700651

This has been affecting me too as of today.

This was referenced Feb 16, 2023
Closed
Merged
ChrisThrasher added a commit to ChrisThrasher/argon that referenced this pull request Feb 17, 2023
@ChrisThrasher
DO NOT MERGE: Install pkg-config
52ab48d 
actions/runner-images#7125

Waiting on this PR to be merged
ChrisThrasher added a commit to ChrisThrasher/argon that referenced this pull request Feb 17, 2023
@ChrisThrasher
DO NOT MERGE: Install pkg-config
a3249a0 
actions/runner-images#7125

Waiting on this PR to be merged
ChrisThrasher added a commit to ChrisThrasher/argon that referenced this pull request Feb 17, 2023
@ChrisThrasher
DO NOT MERGE: Install pkg-config
5798fab 
actions/runner-images#7125

Waiting on this PR to be merged
ChrisThrasher added a commit to ChrisThrasher/argon that referenced this pull request Feb 17, 2023
@ChrisThrasher
DO NOT MERGE: Install pkg-config
05a177e 
actions/runner-images#7125

Waiting on this PR to be merged
@pfeerick pfeerick mentioned this pull request Feb 17, 2023
Merged
@akoeplinger akoeplinger mentioned this pull request Feb 17, 2023
Closed
Shelnutt2 added a commit to TileDB-Inc/TileDB that referenced this pull request Feb 17, 2023
@Shelnutt2
Install pkg-config for MacOS release CI
e150271 
The github actions/azure devops MacOS image update `20230214.1` removed
an implicit installation of pkg-config. This works around the issue but
installing pkg-config from brew.

This can be removed if the CI images get an explicit install of
pkg-config, i.e actions/runner-images#7125 .
@Shelnutt2 Shelnutt2 mentioned this pull request Feb 17, 2023
Merged
Shelnutt2 added a commit to TileDB-Inc/TileDB that referenced this pull request Feb 17, 2023
@Shelnutt2
Install pkg-config for MacOS release CI
fda72ec 
The github actions/azure devops MacOS image update `20230214.1` removed
an implicit installation of pkg-config. This works around the issue but
installing pkg-config from brew.

This can be removed if the CI images get an explicit install of
pkg-config, i.e actions/runner-images#7125 .
ihnorton pushed a commit to TileDB-Inc/TileDB that referenced this pull request Feb 17, 2023
@Shelnutt2
Install pkg-config for MacOS release CI (#3908)
c8e49ba 
The github actions/azure devops MacOS image update `20230214.1` removed an implicit installation of pkg-config. This works around the issue but installing pkg-config from brew.

This can be removed if the CI images get an explicit install of pkg-config, i.e actions/runner-images#7125 .

---
TYPE: NO_HISTORY
DESC: NO_HISTORY
github-actions bot pushed a commit to TileDB-Inc/TileDB that referenced this pull request Feb 17, 2023
@Shelnutt2 @github-actions
Install pkg-config for MacOS release CI (#3908)
209d5c0 
The github actions/azure devops MacOS image update `20230214.1` removed an implicit installation of pkg-config. This works around the issue but installing pkg-config from brew.

This can be removed if the CI images get an explicit install of pkg-config, i.e actions/runner-images#7125 .

---
TYPE: NO_HISTORY
DESC: NO_HISTORY
github-actions bot pushed a commit to TileDB-Inc/TileDB that referenced this pull request Feb 17, 2023
@Shelnutt2 @github-actions
Install pkg-config for MacOS release CI (#3908)
f9b11ac 
The github actions/azure devops MacOS image update `20230214.1` removed an implicit installation of pkg-config. This works around the issue but installing pkg-config from brew.

This can be removed if the CI images get an explicit install of pkg-config, i.e actions/runner-images#7125 .

---
TYPE: NO_HISTORY
DESC: NO_HISTORY
github-actions bot pushed a commit to TileDB-Inc/TileDB that referenced this pull request Feb 17, 2023
@Shelnutt2 @github-actions
Install pkg-config for MacOS release CI (#3908)
ad8d3dc 
The github actions/azure devops MacOS image update `20230214.1` removed an implicit installation of pkg-config. This works around the issue but installing pkg-config from brew.

This can be removed if the CI images get an explicit install of pkg-config, i.e actions/runner-images#7125 .

---
TYPE: NO_HISTORY
DESC: NO_HISTORY
ihnorton pushed a commit to TileDB-Inc/TileDB that referenced this pull request Feb 17, 2023
@github-actions @Shelnutt2
Install pkg-config for MacOS release CI (#3908) (#3914)
9a3c64d 
The github actions/azure devops MacOS image update `20230214.1` removed an implicit installation of pkg-config. This works around the issue but installing pkg-config from brew.

This can be removed if the CI images get an explicit install of pkg-config, i.e actions/runner-images#7125 .

---
TYPE: NO_HISTORY
DESC: NO_HISTORY

Co-authored-by: Seth Shelnutt <seth@tiledb.io>
ihnorton pushed a commit to TileDB-Inc/TileDB that referenced this pull request Feb 17, 2023
@github-actions @Shelnutt2
Install pkg-config for MacOS release CI (#3908) (#3913)
3eea160 
The github actions/azure devops MacOS image update `20230214.1` removed an implicit installation of pkg-config. This works around the issue but installing pkg-config from brew.

This can be removed if the CI images get an explicit install of pkg-config, i.e actions/runner-images#7125 .

---
TYPE: NO_HISTORY
DESC: NO_HISTORY

Co-authored-by: Seth Shelnutt <seth@tiledb.io>
ihnorton pushed a commit to TileDB-Inc/TileDB that referenced this pull request Feb 17, 2023
@github-actions @Shelnutt2
Install pkg-config for MacOS release CI (#3908) (#3912)
8faec4f 
The github actions/azure devops MacOS image update `20230214.1` removed an implicit installation of pkg-config. This works around the issue but installing pkg-config from brew.

This can be removed if the CI images get an explicit install of pkg-config, i.e actions/runner-images#7125 .

---
TYPE: NO_HISTORY
DESC: NO_HISTORY

Co-authored-by: Seth Shelnutt <seth@tiledb.io>
ChrisThrasher added a commit to ChrisThrasher/argon that referenced this pull request Feb 17, 2023
@ChrisThrasher
Work around macOS GitHub Actions runner bug
642d398 
actions/runner-images#7125

Waiting on this PR to be merged
@dyfer dyfer mentioned this pull request Feb 18, 2023
Merged
2 tasks
kleisauke added a commit to kleisauke/libvips that referenced this pull request Feb 18, 2023
@kleisauke
CI: ensure pkg-config is installed on macOS
dd051c3 
See: actions/runner-images#7125
@kleisauke kleisauke mentioned this pull request Feb 18, 2023
Merged
kleisauke added a commit to libvips/libvips that referenced this pull request Feb 18, 2023
@kleisauke
CI: ensure pkg-config is installed on macOS (#3350)
d4962ff 
See: actions/runner-images#7125
@mikhailkoliada mikhailkoliada merged commit 09baf89 into actions:main Feb 19, 2023
@erik-bershel erik-bershel deleted the macos-add-pkg-config branch February 19, 2023 11:46
@straight-shoota straight-shoota mentioned this pull request Feb 19, 2023
Closed
@AenBleidd AenBleidd mentioned this pull request Feb 19, 2023
Merged
@dyfer dyfer mentioned this pull request Feb 19, 2023
Merged
3 tasks
@BewareMyPower BewareMyPower mentioned this pull request Feb 20, 2023
Merged
4 tasks
This was referenced Feb 20, 2023
Merged
Merged
@erik-bershel erik-bershel mentioned this pull request Feb 20, 2023
Closed
10 tasks
@amirmalka amirmalka mentioned this pull request Feb 21, 2023
Merged
@bogdan-damian-bgd bogdan-damian-bgd mentioned this pull request Feb 21, 2023
Closed
10 tasks
sebastiangrimberg added a commit to awslabs/palace that referenced this pull request Feb 22, 2023
@sebastiangrimberg
Fix pkg-config installation for macOS
2b7473a 
Seems related to actions/runner-images#7125. Also clean up clang-format-15 install.
@sebastiangrimberg sebastiangrimberg mentioned this pull request Feb 22, 2023
Merged
mpilgrem added a commit to commercialhaskell/stack that referenced this pull request Mar 4, 2023
@mpilgrem
pkg-config supplied in GitHub Hosted Runner for macOS
6d4be95 
`pkg-config` is now supplied in the GitHub Hosted Runner for macOS. See actions/runner-images#7125.
@mpilgrem mpilgrem mentioned this pull request Mar 4, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MICHAEL11223344 MICHAEL11223344 MICHAEL11223344 approved these changes

@mikhailkoliada mikhailkoliada mikhailkoliada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erik-bershel @ChrisThrasher @mikhailkoliada @MICHAEL11223344