Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic worker update cause container to crash #484

Closed
MalloZup opened this issue May 17, 2020 · 8 comments
Closed

Automatic worker update cause container to crash #484

MalloZup opened this issue May 17, 2020 · 8 comments
Labels
bug Something isn't working

Comments

@MalloZup
Copy link

MalloZup commented May 17, 2020

Description:

worker version: 2.169.1

Hi all, I'm running the worker as self-hosted.
I have build my own container image with the binary etc.

After some time, I was not able to reproduce why container died ( since I run it as service in detached mode).

I found out that the worker try to update itself automatically and then it fails.

2020-05-17 20:23:37Z: Listening for Jobs
Runner update in progress, do not shutdown runner.
Downloading 2.262.1 runner
Waiting for current job finish running.
Generate and execute update script.
Runner will exit shortly for update, should back online within 10 seconds.
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found
/home/CI/_work/_update.sh: line 31: ping: command not found

I think automatic update the worker is not what user want generally by default.

I think it should be an option like to either enabling automatic updating if wanted but not the default behaviour.

thx! let me know

@MalloZup MalloZup added the bug Something isn't working label May 17, 2020
@MalloZup
Copy link
Author

as update, I have installed the ping cmd but the container still doesn't recover

@bryanmacfarlane
Copy link
Member

Is your entrypoint run.sh? Try runsvc.sh which handles updates.

@bryanmacfarlane
Copy link
Member

bryanmacfarlane commented May 18, 2020

Read all of this issue: #246. - this is a dupe of that issue.

@MalloZup
Copy link
Author

@bryanmacfarlane thx for feedback I will get an eye on that issue.

Closing this as duplicate

@bryanmacfarlane
Copy link
Member

Let us know if runsvc.sh works for you.

@MalloZup
Copy link
Author

@bryanmacfarlane

Runner update in progress, do not shutdown runner.
Downloading 2.262.1 runner
Waiting for current job finish running.
Generate and execute update script.
Runner will exit shortly for update, should back online within 10 seconds.
Runner listener exited with error code 3
Runner listener exit because of updating, re-launch runner in 5 seconds.
Starting Runner listener with startup type: service
Started listener process

That worked for me

@bryanmacfarlane
Copy link
Member

Awesome

@NPellet
Copy link

NPellet commented Sep 14, 2020

Works very nicely :)
Quick note for those who end up here.
runsvc.sh is in ./bin/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants