Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node20: 20.8.1 → 20.13.1 #3284

Merged
merged 4 commits into from
May 14, 2024
Merged

Upgrade node20: 20.8.1 → 20.13.1 #3284

merged 4 commits into from
May 14, 2024

Conversation

pje
Copy link
Member

@pje pje commented May 13, 2024

@pje
Copy link
Member Author

pje commented May 13, 2024

Building a new release of alpine_nodejs for node v20.13.1 over here: https://github.com/actions/alpine_nodejs/actions/runs/9068046702

@pje pje marked this pull request as ready for review May 13, 2024 21:29
@pje pje requested a review from a team as a code owner May 13, 2024 21:29
@pje pje self-assigned this May 13, 2024
NODE16_VERSION="16.20.2"
NODE20_VERSION="20.8.1"
NODE20_VERSION="20.13.1"
# used only for win-arm64, remove node16 unofficial version when official version is available
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does win-arm64 not having node20?

Copy link
Member Author

@pje pje May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They do! They've got a release for win-arm64 at 20.13.1: https://nodejs.org/dist/v20.13.1/

I think that comment was meant for node16, which doesn't seem to have an official win-arm64 release: https://nodejs.org/dist/v16.20.2/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move that comment to the end of the line so it's more obvious which variable it's referring to:
2503260

TingluoHuang
TingluoHuang previously approved these changes May 13, 2024
@pje
Copy link
Member Author

pje commented May 14, 2024

This is ready to go! Anyone from @actions/actions-runtime should feel free to merge this for the next runner release, otherwise I'll plan to do so early next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants