Fix issues for composite actions (Run Service flow) #3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
force-pushed
the
users/ericsciple/24-08-embed
branch
2 times, most recently
from
12e67bd to
ce2086c
Compare
ericsciple
force-pushed
the
users/ericsciple/24-08-embed
branch
from
ce2086c to
deade9c
Compare
ericsciple
commented
Aug 30, 2024
| @@ -365,6 +366,10 @@ public IExecutionContext CreateChild( | |||
|
|
|||
| var child = new ExecutionContext(this, isEmbedded); | |||
| child.Initialize(HostContext); | |||
| if ((Global.Variables.GetBoolean("RunService.FixEmbeddedIssues") ?? false) && embeddedIssueCollector != null) | |||
| { | |||
| child._embeddedIssueCollector = embeddedIssueCollector; | |||
There was a problem hiding this comment.
Currently _embeddedIssueCollector is incorrectly set in the constructor here
It's used in the method Complete to populate the roll-up step annotations here which is then published as step results only for "Task" execution contexts (i.e. not for the "Job" execution context.
ericsciple
commented
Sep 3, 2024
| @@ -154,6 +153,7 @@ public sealed class ExecutionContext : RunnerService, IExecutionContext | |||
| private CancellationTokenSource _cancellationTokenSource; | |||
| private TaskCompletionSource<int> _forceCompleted = new(); | |||
| private bool _throttlingReported = false; | |||
| private List<Issue> _embeddedIssueCollector; | |||
There was a problem hiding this comment.
Removed readonly because initialized by the method CreateChild now
TingluoHuang
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.