Bump dotnet SDK to dotnet 8. #3500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rentziass
approved these changes
Oct 16, 2024
YorikSar
added a commit
to YorikSar/nixpkgs
that referenced
this pull request
Nov 15, 2024
* remove mentions of Node.js 16 which is not supported anymore see actions/runner#3503 * switch to .Net SDK 8 see actions/runner#3500 * fix source path discovery in deterministic build: runtime assumes that the root of the project is `/_`, replace it with actual `/build/src` so that tests can find their data.
13 tasks
YorikSar
added a commit
to YorikSar/nixpkgs
that referenced
this pull request
Nov 15, 2024
* remove mentions of Node.js 16 which is not supported anymore see actions/runner#3503 * switch to .Net SDK 8 see actions/runner#3500 * fix source path discovery in deterministic build: runtime assumes that the root of the project is `/_`, replace it with actual `/build/src` so that tests can find their data.
YorikSar
added a commit
to YorikSar/nixpkgs
that referenced
this pull request
Nov 17, 2024
* remove mentions of Node.js 16 which is not supported anymore see actions/runner#3503 * switch to .Net SDK 8 see actions/runner#3500 * fix source path discovery in deterministic build: runtime assumes that the root of the project is `/_`, replace it with actual `/build/src` so that tests can find their data.
github-actions bot
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Nov 19, 2024
* remove mentions of Node.js 16 which is not supported anymore see actions/runner#3503 * switch to .Net SDK 8 see actions/runner#3500 * fix source path discovery in deterministic build: runtime assumes that the root of the project is `/_`, replace it with actual `/build/src` so that tests can find their data. (cherry picked from commit db1d5cf)
YorikSar
added a commit
to YorikSar/nixpkgs
that referenced
this pull request
Nov 19, 2024
* remove mentions of Node.js 16 which is not supported anymore see actions/runner#3503 * switch to .Net SDK 8 see actions/runner#3500 * fix source path discovery in deterministic build: runtime assumes that the root of the project is `/_`, replace it with actual `/build/src` so that tests can find their data. (cherry picked from commit db1d5cf)
osnyx
pushed a commit
to flyingcircusio/nixpkgs
that referenced
this pull request
Nov 25, 2024
* remove mentions of Node.js 16 which is not supported anymore see actions/runner#3503 * switch to .Net SDK 8 see actions/runner#3500 * fix source path discovery in deterministic build: runtime assumes that the root of the project is `/_`, replace it with actual `/build/src` so that tests can find their data. (cherry picked from commit db1d5cf) (cherry picked from commit 2c6e9e4)
theihor
added a commit
to theihor/bpfci-runner
that referenced
this pull request
Nov 28, 2024
Github Actions Runner.Listener x86_64 binary version 2.321.0 has been crashing with segfault on startup when emulated on s390x [1]. Ilya pointed out, that the root cause of this crash is most likely a qemu issue [2]. .NET 8 turns on "write xor execute" feature [3] by default. And GH actions runner 2.320.0->2.321.0 update includes an upgrade to .NET 8 [4]. Ilya suggested opting out of this feature in our environment to mitigate the failure. I tested this with manually built runner immage on one for s390x BPF CI hosts: the runner doesn't crash. [1] actions/runner#3583 [2] https://gitlab.com/qemu-project/qemu/-/issues/2600 [3] https://devblogs.microsoft.com/dotnet/announcing-net-6-preview-7/#runtime:-w^x-(write-xor-execute)-support-for-all-platforms-and-architectures [4] actions/runner#3500 Suggested-by: Ilya Leoshkevich <iii@linux.ibm.com> Signed-off-by: Ihor Solodrai <isolodrai@meta.com>
theihor
added a commit
to kernel-patches/runner
that referenced
this pull request
Nov 28, 2024
Github Actions Runner.Listener x86_64 binary version 2.321.0 has been crashing with segfault on startup when emulated on s390x [1]. Ilya pointed out, that the root cause of this crash is most likely a qemu issue [2]. .NET 8 turns on "write xor execute" feature [3] by default. And GH actions runner 2.320.0->2.321.0 update includes an upgrade to .NET 8 [4]. Ilya suggested opting out of this feature in our environment to mitigate the failure. I tested this with manually built runner immage on one for s390x BPF CI hosts: the runner doesn't crash. [1] actions/runner#3583 [2] https://gitlab.com/qemu-project/qemu/-/issues/2600 [3] https://devblogs.microsoft.com/dotnet/announcing-net-6-preview-7/#runtime:-w^x-(write-xor-execute)-support-for-all-platforms-and-architectures [4] actions/runner#3500 Suggested-by: Ilya Leoshkevich <iii@linux.ibm.com> Signed-off-by: Ihor Solodrai <isolodrai@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dotnet 6 is approaching end of life, and this PR updates the dotnet SDK to dotnet 8.
There will be other followup PR to clean up more stuff.
Dotnet8 is no longer supported on
centos7, this means the runner will not work on that platform anymore.