Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e2e tests and e2e test infrastructure #414

Merged
merged 6 commits into from
Apr 20, 2023

Conversation

IvanZosimov
Copy link
Contributor

Description:
In the scope of this PR, the following changes were made:

  1. The code of the verify-dotnet.ps1 script was updated, now it is possible to:
        - Specify dotnet version patterns using regular expressions;
        - Specify any number of dotnet version patterns (previously it was 3 at most);
        - Optionally check if nuget.config file is generated;

The verify-dotnet.ps1 creates a temporary global.json file for each tested version of the .NET SDK.  It allows to build and run unit-tests in a sample c# project (e2e-test-csproj) using each installed version of the .NET.

  1. The bash script verify-dotnet.sh was completely removed, as the only reason for it was to run in the Docker container here

  2. The sample c# project sample-csproj was updated, now:
         - Project is targeted to the concrete .NET SDK using environment variable that is set in verify-dotnet.ps1`;
         - Unit-test is updated;

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@IvanZosimov IvanZosimov requested a review from a team as a code owner April 19, 2023 13:42
@dmitry-shibanov dmitry-shibanov merged commit fc8786b into actions:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants