-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for gotip and latest #34
Conversation
/cc @zikaeroh |
Ubuntu tests are passing, getting errors on Windows. https://github.com/tie/setup-go/runs/349414830 Edit: seems related https://stackoverflow.com/a/37996249 |
Aside from Windows errors, the code is working. Opening for review. |
I left some comments, but I'm still pretty iffy on the magic of using an API to fetch the commit, grabbing an archive, and creating a VERSION file, given how far it is from an actual build that people working with The main use case of running Being too far removed from the version output expected by the Go devs, or the install process in the documentation I think may not be a good idea. I'd really consider another method where a plain |
I’ve reconsidered my decision on using archives. Plain We could cache |
Almost there on another branch, having a problem with lint/prettifier being not helpful at all (it just fails and tells to read the log file for details). |
Also closes #35 because I ended up refactoring tests and found this issue. |
Ready for review again. /cc @zikaeroh I hope I’ve addressed your concerns. Last CI run: https://github.com/tie/setup-go/commit/8d6c88b10d1e37b1bffe029bd5e441eacf067633/checks |
Interested in these features potentially but master changed drastically with the v2-beta changes. Do you want to take a stab at implementing on top of that code? |
Looking over this soon. assigning to me |
Is there an estimated timeline when this will be implemented? This will be really helpful for us to transit into using Github Action. |
Closing this PR since it’s out-of-date. |
This PR adds support for building Go
tip
from source and an aliaslatest
for the major release.Closes #21
Closes #31
Closes #32
Closes #35