Skip to content
This repository has been archived by the owner on Dec 12, 2020. It is now read-only.

Add Licensed to verify third party dependencies #33

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Add Licensed to verify third party dependencies #33

merged 1 commit into from
Sep 23, 2020

Conversation

thboop
Copy link
Collaborator

@thboop thboop commented Sep 9, 2020

GitHub has a tool called licensed which helps us to verify that the node modules we are using are appropriately licensed for what we are using them for. It also helps to verify that the license a node module claims to be under matches the license it.

If you were previously checking in a license in the dist file, this can replace that flow.

This PR adds:

  • A workflow to check licenses on pull requests and pushes to the main branch
  • A licensed.yml file used to configure licensed
  • A number of files into the .licenses directory which contain our dependencies and their appropriate licenses

How does this impact me?

  • You may need to locally install licensed and run licensed cache to update the dependency cache if you install a new production dependency.
    • If licensed cache is unable to determine the dependency, you may need to modify the cache file yourself to put the correct license.
  • You should still verify the dependency, licensed in a tool to help, but is not a substitute for human review of dependencies
  • Currently, this PR only targets production dependencies, dev dependencies are not included.

@hross hross self-requested a review September 16, 2020 13:22
@hross hross merged commit 2cd7ee6 into actions:main Sep 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants