Describe cache key format in readme #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-shibanov
approved these changes
Sep 2, 2021
2 tasks
copybara-service bot
pushed a commit
to google/google-java-format
that referenced
this pull request
Sep 9, 2021
As of August 30, ["`setup-java` supports caching for both Gradle and Maven projects"](https://github.blog/changelog/2021-08-30-github-actions-setup-java-now-supports-dependency-caching/). This helps to reduce the amount of boilerplate code in the workflow file. More details can be found in the [corresponding docs](https://github.com/actions/setup-java#caching-packages-dependencies). (And if you wonder what's the used cache key format: actions/setup-java#215) Fixes #660 COPYBARA_INTEGRATE_REVIEW=#660 from beatngu13:patch-1 47e262b PiperOrigin-RevId: 395674252
|
@dmitry-shibanov thank you for reviewing and approving. That was 20 days ago, is there anything else I can do get this merged? |
MaksimZhukov
approved these changes
Dec 29, 2021
|
Hello @beatngu13! Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Several users, including myself, wondered what cache key format is being used under the hood (see e.g. here or here). This PR adds a corresponding description – based on
computeCacheKey– to theREADME.md.Related issue:
n/a
Check list: