Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an error condition for non jdk Microsoft OpenJDK build #265

Merged

Conversation

dmitry-shibanov
Copy link
Contributor

Description:
In scope of this pull request we update documentation and add logic to throw an error for non jdk versions for Microsoft OpenJDK build. Microsoft OpenJDK build supports only jdk for now.

Related issue:

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@dmitry-shibanov
Copy link
Contributor Author

Hello @brcrista. Could you please take a look at these changes.

@sullis
Copy link

sullis commented Dec 19, 2021

LGTM

@dmitry-shibanov dmitry-shibanov merged commit f0bb916 into actions:main Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants