Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action failed after configuring poetry on Windows #407

Closed
2 of 5 tasks
he0119 opened this issue May 26, 2022 · 4 comments
Closed
2 of 5 tasks

Action failed after configuring poetry on Windows #407

he0119 opened this issue May 26, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@he0119
Copy link

he0119 commented May 26, 2022

Description:
After configuring poetry on Windows, action failed with Error: Unexpected token # in JSON.

Action version:
v3.1

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Tools version:
3.7, 3.8, 3.9, 3.10

Repro steps:
https://github.com/he0119/action-test/blob/main/.github/workflows/python.yml

Configuring poetry before setup-python

    - name: Install poetry
      run: pipx install poetry --pip-args=--pre
    - run: poetry config virtualenvs.prefer-active-python true
    - uses: actions/setup-python@v3
      with:
        python-version: ${{ matrix.python-version }}
        cache: 'poetry'

Expected behavior:
run without error.

Actual behavior:
https://github.com/he0119/action-test/runs/6602490267?check_suite_focus=true#step:5:19

Run actions/setup-python@v3
Successfully setup CPython (3.10.4)
"C:\Program Files (x8[6](https://github.com/he0119/action-test/runs/6602218881?check_suite_focus=true#step:5:7))\pipx_bin\poetry.exe" config --list
cache-dir = "C:\\Users\\runneradmin\\AppData\\Local\\pypoetry\\Cache"
experimental.new-installer = true
installer.max-workers = null
installer.parallel = true
virtualenvs.create = true
virtualenvs.in-project = null
virtualenvs.options.always-copy = false
virtualenvs.options.system-site-packages = false
virtualenvs.path = "{cache-dir}\\virtualenvs"  # C:\Users\runneradmin\AppData\Local\pypoetry\Cache\virtualenvs
virtualenvs.prefer-active-python = true
Error: Unexpected token # in JSON at position 28
@dmitry-shibanov
Copy link
Contributor

Hello @he0119. Thank you for your report. We've prepared a pull request to resolve the issue.

@dmitry-shibanov
Copy link
Contributor

Hello @he0119. Sorry for the late response. We merged the fix. We have not released a new version of the setup-python action yet. Could you please test your project on the main branch of setup-python and confirm that everything works as expected ?

@he0119
Copy link
Author

he0119 commented Jun 7, 2022

Yes, everything works fine now.

@dmitry-shibanov
Copy link
Contributor

Hello @he0119. The new major version was released with fix. Could you please confirm that everything works as expected ?

@he0119 he0119 closed this as completed Jun 10, 2022
eugenesvk added a commit to eugenesvk/xontrib-cookiecutter that referenced this issue Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants