Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove skip-stale-issue-message and skip-stale-pr-message options #455

Closed
C0ZEN opened this issue May 23, 2021 · 0 comments · Fixed by #457
Closed

Remove skip-stale-issue-message and skip-stale-pr-message options #455

C0ZEN opened this issue May 23, 2021 · 0 comments · Fixed by #457
Labels
bug Something isn't working

Comments

@C0ZEN
Copy link
Contributor

C0ZEN commented May 23, 2021

Describe your issue

These options seems useless to me.
We can simply define for example that no message will be sent if stale-issue-message is empty.
Also, it's strange that there is no option to cover the close message.

I can provide a PR.
@C0ZEN C0ZEN added the bug Something isn't working label May 23, 2021
@C0ZEN C0ZEN mentioned this issue May 23, 2021
Closed
C0ZEN added a commit to C0ZEN/stale that referenced this issue May 23, 2021
@C0ZEN
feat(options): simplify config by removing skip stale message options
a324e60 
Closes actions#405
Closes actions#455

BREAKING CHANGES: remove skip-stale-issue-message and skip-stale-pr-message options. If you used this option, replace it by an empty message for the options stale-issue-message and stale-pr-message
@C0ZEN C0ZEN mentioned this issue May 23, 2021
Merged
3 tasks
C0ZEN added a commit to C0ZEN/stale that referenced this issue May 25, 2021
@C0ZEN
feat(options): simplify config by removing skip stale message options
73417c5 
Closes actions#405
Closes actions#455

BREAKING CHANGES: remove skip-stale-issue-message and skip-stale-pr-message options. If you used this option, replace it by an empty message for the options stale-issue-message and stale-pr-message
luketomlinson pushed a commit that referenced this issue May 25, 2021
@C0ZEN
feat(options): simplify config by removing skip stale message options (…
6ec637d 
…#457)

* feat(options): simplify config by removing skip stale message options

Closes #405
Closes #455

BREAKING CHANGES: remove skip-stale-issue-message and skip-stale-pr-message options. If you used this option, replace it by an empty message for the options stale-issue-message and stale-pr-message

* build(dist): update dist

also lint some files

* docs(readme): update the docs by removing the skip options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(options): simplify config by removing skip stale message options C0ZEN/stale
1 participant
@C0ZEN