The logs about the close label removal are not clear/complete #462
Labels
bug
Something isn't working
Comments
C0ZEN
added a commit
to C0ZEN/stale
that referenced
this issue
May 24, 2021
A log was missing when the option was configured but the close label was not present on the issue/PR Change the log about not removing the close label to explicitly mention that this behaviour occur because the option is not configured Fixes actions#462
3 tasks
C0ZEN
added a commit
to C0ZEN/stale
that referenced
this issue
May 25, 2021
A log was missing when the option was configured but the close label was not present on the issue/PR Change the log about not removing the close label to explicitly mention that this behaviour occur because the option is not configured Fixes actions#462
C0ZEN
added a commit
to C0ZEN/stale
that referenced
this issue
Jun 3, 2021
A log was missing when the option was configured but the close label was not present on the issue/PR Change the log about not removing the close label to explicitly mention that this behaviour occur because the option is not configured Fixes actions#462
luketomlinson
pushed a commit
that referenced
this issue
Jun 7, 2021
* feat(logs): improve the logs when removing the close label A log was missing when the option was configured but the close label was not present on the issue/PR Change the log about not removing the close label to explicitly mention that this behaviour occur because the option is not configured Fixes #462 * feat(dry-run): display the logs and count the operations the dry-run checks were cancelling way sooner the workflow the logs and the count of operations could not occur in dry run due to this the goal of the dry run is just to skip some logic regarding the api calls to avoid altering the repos but the goal IMO is to also make them reflect the real world run so this change allow this BTW it also allow now to test the consumed operations Fixes #461 * feat(logs): add more logs to debug the stale label removal * chore(index): update index * chore(dry-run): fix bad dry-run conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe your issue
From this issue #451, we can see these logs:
There is nothing following the log about the close label removal.
It's since the option is not configured.
Having a better log to explain this would be nice.
Now, when the option is configured and that the label is not present, no log will appear.
Having a log saying that the label is not in the issue/PR would be better as well.
I will provide a PR.
The text was updated successfully, but these errors were encountered: