Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry-run allow to add labels and update the issues :/ #499

Closed
C0ZEN opened this issue Jun 8, 2021 · 0 comments · Fixed by #500
Closed

Dry-run allow to add labels and update the issues :/ #499

C0ZEN opened this issue Jun 8, 2021 · 0 comments · Fixed by #500
Labels
bug Something isn't working

Comments

@C0ZEN
Copy link
Contributor

C0ZEN commented Jun 8, 2021

Describe your issue

This PR introduced an issue #463 regarding the dry-run.
The project doesn't have test covering the operations per run, so it's only an assumption based on my understanding of the current code.

Here is the lack of dry-run wrapper:

await this.client.issues.addLabels({

await this.client.issues.addLabels({

await this.client.issues.update({

And I think that this block should not be cancelled in a dry-run.

if (!this.options.debugOnly) {

Sorry!

@C0ZEN C0ZEN added the bug Something isn't working label Jun 8, 2021
C0ZEN added a commit to C0ZEN/stale that referenced this issue Jun 8, 2021
Bring back the dry-run by default for the tests - bad idea to disable it sorry
Fix bad documentation array format
Fixes actions#499
luketomlinson pushed a commit that referenced this issue Jun 10, 2021
Bring back the dry-run by default for the tests - bad idea to disable it sorry
Fix bad documentation array format
Fixes #499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant