-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize API calls #1033
Optimize API calls #1033
Conversation
3e8b587
to
41108c8
Compare
c988721
to
6afea3f
Compare
46a9b53
to
6148637
Compare
9f8d82d
to
75127e6
Compare
a6c5bfe
to
dcfe49d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks alright to me :) Tested a workflow run using this branch and everything works error-free. The comments I left below are just nitpicks and can be ignored, as there are no problems present. Thank you!
unprocessed issue skipping the issues proceeded during the previous run(s). The state is reset when all the issues are | ||
proceeded. This should be considered for scheduling workflow runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typos in the readme:
s/proceeded/processed/g
Description:
Each next run should not proceed the issues proceed during the previous run. In the other case running from the very beginning never reach the issues beyond API limit.
Changes:
persist
,rehydrate
andreset
methodImplementation details:
Related issue:
link to the related issue.
Check list: