Upgrade Node to v20 #1110

aparnajyothi-y · 2023-11-24T13:42:01Z

Description:
Code changes for Node version upgrade to 20

Related issue:
Feature request

Check list:

Mark if documentation changes are required.
Mark if tests were added or updated to cover the changes.

aparnajyothi-y · 2023-12-01T12:46:57Z

Please review this PR. Thank you.

MaksimZhukov · 2023-12-06T09:16:26Z

package.json

@@ -1,6 +1,6 @@
 {
  "name": "stale-action",
-  "version": "7.0.0",
+  "version": "8.0.0",


Suggested change

"version": "8.0.0",

"version": "9.0.0",

IvanZosimov · 2023-12-06T10:19:11Z

src/classes/issues-processor.ts

+
+type state_reason_type =
+  | 'completed'
+  | 'reopened'
+  | 'not_planned'
+  | null
+  | undefined;


What was the reason for adding this type?

While I was running npm run test few test and test suites are failed for the code
state_reason: this.options.closeIssueReason || undefined for that I have intialized status_reason and updated the line of code. Now I have rechecked the code and updated the line. All tests passed with same line now.

IvanZosimov · 2023-12-06T10:23:04Z

src/classes/issues-processor.ts

@@ -934,7 +941,7 @@ export class IssuesProcessor {
          repo: context.repo.repo,
          issue_number: issue.number,
          state: 'closed',
-          state_reason: this.options.closeIssueReason || undefined
+          state_reason: this.options.closeIssueReason as state_reason_type


In this code update, you changed the logic. The this.options.closeIssueReason is typed as a string. The code state_reason: this.options.closeIssueReason || undefined means that if the this.options.closeIssueReason is an empty string we assign state_reason with undefined.
In your version of code this logic is changed. If the this.options.closeIssueReason is an empty string you assign state_reason with an empty string. What is the reason for that?

To resolve the failed tests for that particular line I have added the change and I missed the logic that I am assigning the empty string. Now I have updated the logic. Thank you for the clarification.

Bumps actions/stale from 8 to 9. Release notes Sourced from actions/stale's releases. v9.0.0 Breaking Changes Action is now stateful: If the action ends because of operations-per-run then the next run will start from the first unprocessed issue skipping the issues processed during the previous run(s). The state is reset when all the issues are processed. This should be considered for scheduling workflow runs. Version 9 of this action updated the runtime to Node.js 20. All scripts are now run with Node.js 20 instead of Node.js 16 and are affected by any breaking changes between Node.js 16 and 20. What Else Changed Performance optimization that removes unnecessary API calls by @dsame #1033 fixes #792 Logs displaying current github API rate limit by @dsame #1032 addresses #1029 For more information, please read the action documentation and its section about statefulness New Contributors @jmeridth made their first contribution in actions/stale#984 @nikolai-laevskii made their first contribution in actions/stale#1020 @dusan-trickovic made their first contribution in actions/stale#1056 @aparnajyothi-y made their first contribution in actions/stale#1110 Full Changelog: actions/stale@v8...v9.0.0

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/stale](https://togithub.com/actions/stale) | action | major | `v8.0.0` -> `v9.0.0` | --- ### Release Notes <details> <summary>actions/stale (actions/stale)</summary> ### [`v9.0.0`](https://togithub.com/actions/stale/releases/tag/v9.0.0) [Compare Source](https://togithub.com/actions/stale/compare/v8.0.0...v9.0.0) #### Breaking changes 1. Action is now stateful: If the action ends because of [operations-per-run](https://togithub.com/actions/stale#operations-per-run) then the next run will start from the first unprocessed issue skipping the issues processed during the previous run(s). The state is reset when all the issues are processed. This should be considered for scheduling workflow runs. 2\. Version 9 of this action updated the runtime to Node.js 20. All scripts are now run with Node.js 20 instead of Node.js 16 and are affected by any breaking changes between Node.js 16 and 20. #### What else Changed 1. Performance optimization that removes unnecessary API calls by [@dsame](https://togithub.com/dsame) [#1033](https://togithub.com/actions/stale/pull/1033/) fixes [#792](https://togithub.com/actions/stale/issues/792) 2. Logs displaying current github API rate limit by [@dsame](https://togithub.com/dsame) [#1032](https://togithub.com/actions/stale/pull/1032) addresses [#1029](https://togithub.com/actions/stale/issues/1029) \ For more information, please read the [action documentation](https://togithub.com/actions/stale#readme) and its [section about statefulness](https://togithub.com/actions/stale#statefulness) #### New Contributors - [@jmeridth](https://togithub.com/jmeridth) made their first contribution in [https://github.com/actions/stale/pull/984](https://togithub.com/actions/stale/pull/984) - [@nikolai-laevskii](https://togithub.com/nikolai-laevskii) made their first contribution in [https://github.com/actions/stale/pull/1020](https://togithub.com/actions/stale/pull/1020) - [@dusan-trickovic](https://togithub.com/dusan-trickovic) made their first contribution in [https://github.com/actions/stale/pull/1056](https://togithub.com/actions/stale/pull/1056) - [@aparnajyothi-y](https://togithub.com/aparnajyothi-y) made their first contribution in [https://github.com/actions/stale/pull/1110](https://togithub.com/actions/stale/pull/1110) **Full Changelog**: actions/stale@v8...v9.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Hapag-Lloyd/Renovate-Global-Configuration).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Bumps actions/stale from 8 to 9. Release notes Sourced from actions/stale's releases. v9.0.0 Breaking Changes Action is now stateful: If the action ends because of operations-per-run then the next run will start from the first unprocessed issue skipping the issues processed during the previous run(s). The state is reset when all the issues are processed. This should be considered for scheduling workflow runs. Version 9 of this action updated the runtime to Node.js 20. All scripts are now run with Node.js 20 instead of Node.js 16 and are affected by any breaking changes between Node.js 16 and 20. What Else Changed Performance optimization that removes unnecessary API calls by @dsame #1033 fixes #792 Logs displaying current github API rate limit by @dsame #1032 addresses #1029 For more information, please read the action documentation and its section about statefulness New Contributors @jmeridth made their first contribution in actions/stale#984 @nikolai-laevskii made their first contribution in actions/stale#1020 @dusan-trickovic made their first contribution in actions/stale#1056 @aparnajyothi-y made their first contribution in actions/stale#1110 Full Changelog: actions/stale@v8...v9.0.0

Upgrade to v20

4ea15c3

aparnajyothi-y requested a review from a team as a code owner November 24, 2023 13:42

aparnajyothi-y added 6 commits November 24, 2023 19:23

Fix for failed checks

17ce8d4

Fix for failed checks

9363123

8.0.0

37d50f5

Packages degraded to older version

f2b2e4c

licensed update

3a0912f

format-check

bd60dbb

MaksimZhukov reviewed Dec 6, 2023

View reviewed changes

IvanZosimov reviewed Dec 6, 2023

View reviewed changes

aparnajyothi-y added 3 commits December 6, 2023 17:51

Updated the logic

327ab26

Format-check

5c341af

9.0.0

13297c9

MaksimZhukov approved these changes Dec 6, 2023

View reviewed changes

IvanZosimov approved these changes Dec 6, 2023

View reviewed changes

marko-zivic-93 approved these changes Dec 7, 2023

View reviewed changes

aparnajyothi-y merged commit 28ca103 into actions:main Dec 7, 2023
8 checks passed

SvenStaehs mentioned this pull request Dec 12, 2023

Update default runtime to node 20 #1098

Open

Cabo999 approved these changes Mar 6, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Node to v20 #1110

Upgrade Node to v20 #1110

aparnajyothi-y commented Nov 24, 2023 •

edited

Loading

aparnajyothi-y commented Dec 1, 2023

MaksimZhukov Dec 6, 2023

IvanZosimov Dec 6, 2023

aparnajyothi-y Dec 6, 2023 •

edited

Loading

IvanZosimov Dec 6, 2023

aparnajyothi-y Dec 6, 2023

Upgrade Node to v20 #1110

Upgrade Node to v20 #1110

Conversation

aparnajyothi-y commented Nov 24, 2023 • edited Loading

aparnajyothi-y commented Dec 1, 2023

MaksimZhukov Dec 6, 2023

Choose a reason for hiding this comment

IvanZosimov Dec 6, 2023

Choose a reason for hiding this comment

aparnajyothi-y Dec 6, 2023 • edited Loading

Choose a reason for hiding this comment

IvanZosimov Dec 6, 2023

Choose a reason for hiding this comment

aparnajyothi-y Dec 6, 2023

Choose a reason for hiding this comment

aparnajyothi-y commented Nov 24, 2023 •

edited

Loading

aparnajyothi-y Dec 6, 2023 •

edited

Loading