Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(logs): coloured logs #465

Merged
merged 5 commits into from
Jun 2, 2021
Merged

fix(logs): coloured logs #465

merged 5 commits into from
Jun 2, 2021

Conversation

C0ZEN
Copy link
Contributor

@C0ZEN C0ZEN commented May 25, 2021 •
edited
Loading

Changes

Fixes #459

@C0ZEN C0ZEN marked this pull request as ready for review May 25, 2021 18:13
@C0ZEN C0ZEN requested a review from a team as a code owner May 25, 2021 18:13
C0ZEN added 4 commits May 25, 2021 20:18
@C0ZEN
refactor(logs): replace chalk by ansi-styles
8419015
@C0ZEN
test(logs): fix the failing tests due to ansi styles
220ee82 
I was not able to disable or mock ansi-styles so instead I found a way to make the tests pass
it's not perfect but it's still nice because the logs will keep their trustful colour when running through the tests
@C0ZEN
refactor(logs): simplify the syntax to colour the logs
de82357
@C0ZEN
chore(rebase): update files due to rebase
57cc23b
@C0ZEN C0ZEN force-pushed the fix/coloured-logs branch from 57a1997 to 57cc23b Compare May 25, 2021 18:20
@C0ZEN
Copy link
Contributor Author

C0ZEN commented Jun 1, 2021 •
edited
Loading

@luketomlinson would be nice if you could merge this one

luketomlinson
luketomlinson approved these changes Jun 2, 2021
View reviewed changes
Copy link
Collaborator

@luketomlinson luketomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨 Nice work!

@luketomlinson luketomlinson merged commit 5fbbfba into actions:main Jun 2, 2021
@C0ZEN C0ZEN deleted the fix/coloured-logs branch June 27, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luketomlinson luketomlinson luketomlinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub logs not coloured
2 participants
@C0ZEN @luketomlinson