Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'repository.directory' to package manifests #143

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Add 'repository.directory' to package manifests #143

merged 1 commit into from
Sep 25, 2019

Conversation

hmarr
Copy link
Contributor

@hmarr hmarr commented Sep 19, 2019

This is supported by npm (docs). It can help tools like Dependabot figure out what's changed between versions.

@xt0rted
Copy link
Contributor

xt0rted commented Sep 19, 2019

This change was mentioned in #104 (comment). I think for it to fully work with dependabot the RELEASES.md files also need to be renamed.

@hmarr
Copy link
Contributor Author

hmarr commented Sep 19, 2019

Thanks for pointing that out! The other option is just supporting those files in Dependabot. dependabot/dependabot-core#1392 adds support for that.

@hmarr
Copy link
Contributor Author

hmarr commented Sep 19, 2019

Apparently dependabot looks for filenames containing those strings (case-insensitive), so it should already work as release is in the list.

@bryanmacfarlane
Copy link
Member

@xt0rted - it sounds like we're good then since it looks for files that contain release. OK?

@xt0rted
Copy link
Contributor

xt0rted commented Sep 25, 2019

@bryanmacfarlane yea, this should be all that's needed for dependabot to pickup the change logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants