Explicitly import crypto
#1842
Merged
Explicitly import crypto
#1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luketomlinson
approved these changes
Oct 4, 2024
yacaovsnc
approved these changes
Oct 4, 2024
Were these manual tests? Anything we can easily automate to prevent future accidental breakages like this? |
We can run tests against other Node versions besides the current support action Node version. I've validated that this catches the issue described in #1841 - #1843. In the future we should be clear about what Node versions we support for the toolkit, but until then I think it's reasonable to validate that the toolkit at least works with what users currently expect. |
yacaovsnc
approved these changes
Oct 4, 2024
zemnmez-renovate-bot
added a commit
to zemn-me/monorepo
that referenced
this pull request
Oct 4, 2024
##### [`v1.11.1](https://github.com/actions/toolkit/blob/HEAD/packages/core/RELEASES.md#1111) - Fix uses of `crypto.randomUUID` on Node 18 and earlier [#1842](actions/toolkit#1842)
github-merge-queue bot
pushed a commit
to zemn-me/monorepo
that referenced
this pull request
Oct 4, 2024
##### [`v1.11.1](https://github.com/actions/toolkit/blob/HEAD/packages/core/RELEASES.md#1111) - Fix uses of `crypto.randomUUID` on Node 18 and earlier [#1842](actions/toolkit#1842)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1841
cryptohas to be explicitly imported in versions before Node 19, so #1824 broke using these packages.I've validated that importing
cryptoworks as expected on Node 16, 18, and 20:#1841 (comment)