Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group tar's output to prevent it from messing up action logs #94

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

SilverRainZ
Copy link
Contributor

@SilverRainZ SilverRainZ commented Feb 2, 2024

Hello maintainers, Please let me know if this PR is unreasonable.

When running a GitHub workflow, outputs of an action will be automatically grouped by step, but when an action is used as a component of another composite action, outputs from different components have no difference, so authors often use echo ::group::Foo and echo ::endgroup:: to distinguish them.

So when this action is used in composite action (in this case, it is sphinx-notes/pages), the output of tar command messes up logs (especially when there are many files to be archived).

For example:

火狐截图_2024-02-02T13-15-50 318Z (The remaining two thousand lines are not displayed…)

So I patch this action, re-run the job, and everything goes well.

In addition, maybe the IO flush policy of grouped messages is different, and the running duration is accelerated by 1 minute.

@SilverRainZ SilverRainZ requested a review from a team as a code owner February 2, 2024 12:53
SilverRainZ added a commit to sphinx-notes/pages that referenced this pull request Feb 2, 2024
When it is used as a component of a composite action.
Copy link
Contributor

@JamesMGreene JamesMGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a very reasonable improvement. Thank you for your contribution! 💝

@JamesMGreene JamesMGreene merged commit 56afc60 into actions:main Feb 7, 2024
3 checks passed
@JamesMGreene
Copy link
Contributor

This has been released as part of v3.0.1, as well as the latest v3. 🚀

SilverRainZ added a commit to sphinx-notes/pages that referenced this pull request May 2, 2024
SilverRainZ added a commit to sphinx-notes/pages that referenced this pull request May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants