Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure changelog has well-defined main sections #6133

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

deivid-rodriguez
Copy link
Member

@deivid-rodriguez deivid-rodriguez commented Mar 12, 2020

And make sure it stays like that in the future.

And check for similar future typos.
@deivid-rodriguez deivid-rodriguez changed the title Fix a changelog typo Ensure changelog has well-defined main sections Mar 20, 2020
@deivid-rodriguez
Copy link
Member Author

@javierjulio The typo being fixed here was merged as part of #5855, but I think we can still keep the changelog check to prevent future similar typos.

Rebased, it should be ready 👍.

Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks! 👌🏻 Yes I think the check is helpful to have. I love that we have those.

@javierjulio javierjulio merged commit f54de1f into master Mar 20, 2020
@javierjulio javierjulio deleted the fix_changelog_typo branch March 20, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants