Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme and changelog commit reference #633

Closed
wants to merge 2 commits into from
Closed

Update readme and changelog commit reference #633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1675479
Fix commit reference for the PR #604 [skip ci]
dalpo Jan 2, 2016
04b5917
Add some docs for the sort_link block usage [skip ci]
dalpo Jan 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

* Added optional block argument for the `sort_link` method. PR
[#604](https://github.com/activerecord-hackery/ransack/pull/604), commit
[2e6667b](https://github.com/dalpo/ransack/commit/2e6667b).
[997b856](https://github.com/dalpo/ransack/commit/997b856).

*Andrea Dal Ponte*

Expand Down
9 changes: 8 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,14 @@ Ransack.configure do |c|
end
```

You can also use a block if your link markup is hard to fit into the label parameter:

```erb
<%= sort_link(@q, :name) do %>
<strong>Player Name</strong>
<% end %>
```

### Advanced Mode

"Advanced" searches (ab)use Rails' nested attributes functionality in order to
Expand Down Expand Up @@ -775,4 +783,3 @@ directly related to bug reports, pull requests, or documentation improvements.
* Spread the word on Twitter, Facebook, and elsewhere if Ransack's been useful
to you. The more people who are using the project, the quicker we can find and
fix bugs!