feat: Add basic tests for msp files

src/Lessmsi.Tests/LessMsi.Tests.csproj

@@ -53,6 +53,7 @@
     <Reference Include="System" />
     <Reference Include="System.Runtime.Serialization" />
     <Reference Include="System.XML" />
+    <Reference Include="WindowsBase" />
     <Reference Include="wix, Version=2.0.2110.0, Culture=neutral">
       <SpecificVersion>False</SpecificVersion>
       <HintPath>..\..\lib\wix.dll</HintPath>
@@ -83,6 +84,7 @@
     <Compile Include="FileEntryGraph.cs" />
     <Compile Include="MiscTests.cs" />
     <Compile Include="MiscTestsNUnit.cs" />
+    <Compile Include="MspTests.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="TestBase.cs" />
   </ItemGroup>

src/Lessmsi.Tests/MspTests.cs

@@ -0,0 +1,30 @@
+using Xunit;
+
+namespace LessMsi.Tests
+{
+	public class MspTests: TestBase
+	{
+		[Fact]
+		public void MsXml5()
+		{
+			ExpectTables("msxml5.msp", new[] { "MsiPatchMetadata", "MsiPatchSequence" });
+			// Cannot test properties yet, since they are internal in LessMsi.Gui!
+			ExpectStreamCabFiles("msxml5.msp", true);
+		}
+
+		[Fact]
+		public void WPF2_32()
+		{
+			ExpectTables("WPF2_32.msp", new[] { "MsiPatchMetadata", "MsiPatchSequence" });
+			ExpectStreamCabFiles("WPF2_32.msp", true);
+		}
+
+		[Fact]
+		public void SQL2008_AS()
+		{
+			ExpectTables("SQL2008_AS.msp", new[] { "MsiPatchSequence" });
+			ExpectStreamCabFiles("SQL2008_AS.msp", true);
+		}
+
+	}
+}

src/Lessmsi.Tests/TestBase.cs

@@ -4,7 +4,8 @@
 using System.Threading;
 using Xunit;
 using LessIO;
-
+using System.Linq;
+
 namespace LessMsi.Tests
 {
     public class TestBase
@@ -242,6 +243,45 @@ protected Path AppPath
                 var local = new Path(codeBase.LocalPath);
                 return local.Parent;
             }
-        }
-    }
-}
+        }
+
+		[DebuggerHidden]
+		protected void ExpectTables(string sourceFileName, string[] expectedTableNames)
+		{
+			using (var msidb = Msi.MsiDatabase.Create(GetMsiTestFile(sourceFileName)))
+			{
+				Assert.NotNull(msidb);
+				var query = "SELECT * FROM `_Tables`";
+				using (var msiTable = new Msi.ViewWrapper(msidb.OpenExecuteView(query)))
+				{
+					Assert.NotNull(msiTable);
+
+					var tableNames = from record in msiTable.Records
+									 select record[0] as string;
+					// Since we don't care about the order, we sort the lists
+					Assert.Equal(expectedTableNames.OrderBy(s => s), tableNames.OrderBy(s => s));
+				}
+			}
+		}
+
+		[DebuggerHidden]
+		protected void ExpectStreamCabFiles(string sourceFileName, bool hasCab)
+		{
+			using (var stg = new OleStorage.OleStorageFile(GetMsiTestFile(sourceFileName)))
+			{
+				var strm = stg.GetStreams().Where(elem => OleStorage.OleStorageFile.IsCabStream(elem));
+				if (strm != null)
+				{
+					// Rest of the CAB parsing logic is in the UI, can't extract filenames without duplicating code that we want to test..
+					Assert.True(hasCab);
+				}
+				else
+				{
+					// Not expecting to find a cab here
+					Assert.False(hasCab);
+				}
+			}
+		}
+
+	}
+}