Make OpenGUICommand work with paths containing spaces #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I fixed a little issue I had. I tried to explore an .msi file in a folder containing spaces from the Windows context menu, but the LessMSI GUI was unable to find the file. I decided to investigate and found that in OpenGUICommand.cs, paths were not being quoted. For example, the class would execute the GUI with this command:
(there are 4 arguments because of the spaces), instead of:
Obviously this is not a problem if the path does not contain spaces.
Now, I wanted to add a test for this...but I don't know how to test this. If you have any ideas let me know.
-Raphaël