Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement From<Basic> for BasicAuth #327

Merged
merged 3 commits into from
Sep 16, 2023
Merged

Implement From<Basic> for BasicAuth #327

merged 3 commits into from
Sep 16, 2023

Conversation

52
Copy link
Contributor

@52 52 commented Sep 14, 2023 •
edited
Loading

PR Type

Feature

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the nightly rustfmt (cargo +nightly fmt).

Overview

Implements From<Basic> for BasicAuth
Closes #326

@52 52 changed the title implement From<Basic> for BasicAuth Implement From<Basic> for BasicAuth Sep 14, 2023
@robjtede robjtede added A-httpauth Project: actix-web-httpauth B-semver-minor labels Sep 15, 2023
robjtede
robjtede approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't see why not, thanks for the contribution 👍🏻

@robjtede robjtede added this pull request to the merge queue Sep 16, 2023
Merged via the queue into actix:master with commit 55ace79 Sep 16, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede approved these changes

Assignees
No one assigned
Labels
A-httpauth Project: actix-web-httpauth B-semver-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BasicAuth doesn't have constructor from Basic
2 participants
@52 @robjtede