Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of pin_project::project attribute #149

Merged
merged 1 commit into from
Jun 6, 2020

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Jun 5, 2020

pin-project will deprecate the project attribute due to some unfixable
limitations.

Refs: taiki-e/pin-project#225

Although the deprecation of the project attribute has not been released yet, this PR is submitted in advance to avoid the CI from being broken by deprecated warnings.

pin-project will deprecate the project attribute due to some unfixable
limitations.

Refs: taiki-e/pin-project#225
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #149 into master will increase coverage by 0.37%.
The diff coverage is 47.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   61.21%   61.59%   +0.37%     
==========================================
  Files          80       80              
  Lines        5036     5028       -8     
==========================================
+ Hits         3083     3097      +14     
+ Misses       1953     1931      -22     
Impacted Files Coverage Δ
actix-service/benches/and_then.rs 0.00% <0.00%> (ø)
actix-service/src/apply_cfg.rs 0.00% <0.00%> (ø)
actix-service/src/and_then.rs 91.25% <66.66%> (+1.12%) ⬆️
actix-service/src/and_then_apply_fn.rs 89.61% <66.66%> (+1.14%) ⬆️
actix-service/src/then.rs 91.01% <66.66%> (+1.01%) ⬆️
actix-ioframe/src/service.rs 88.00% <100.00%> (+31.13%) ⬆️
actix-service/src/transform.rs 70.83% <100.00%> (+2.83%) ⬆️
actix-connect/tests/test_connect.rs 87.69% <0.00%> (-3.08%) ⬇️
router/src/resource.rs 73.45% <0.00%> (ø)
actix-ioframe/src/dispatcher.rs 55.14% <0.00%> (+0.93%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 755a8bb...9528df4. Read the comment docs.

@JohnTitor JohnTitor merged commit 7140c04 into actix:master Jun 6, 2020
@taiki-e taiki-e deleted the pin-project branch June 6, 2020 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants