Skip to content

actix-http: play with allowing bytes passthrough in the h1 encoder #547

actix-http: play with allowing bytes passthrough in the h1 encoder

actix-http: play with allowing bytes passthrough in the h1 encoder #547

Triggered via pull request November 4, 2024 23:36
Status Failure
Total duration 1m 51s
Artifacts

lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 5 warnings
fmt
Process completed with exit code 1.
clippy: actix-http/src/h1/encoder.rs#L449
[clippy] reported by reviewdog 🐶 error: use of a disallowed/placeholder name `e` --> actix-http/src/h1/encoder.rs:449:35 | 449 | .map_err(|e| io::Error::new(io::ErrorKind::Other, e))?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#disallowed_names = note: `-D clippy::disallowed-names` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::disallowed_names)]` Raw Output: actix-http/src/h1/encoder.rs:449:35:e:error: use of a disallowed/placeholder name `e` --> actix-http/src/h1/encoder.rs:449:35 | 449 | .map_err(|e| io::Error::new(io::ErrorKind::Other, e))?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#disallowed_names = note: `-D clippy::disallowed-names` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::disallowed_names)]` __END__
clippy: actix-http/src/h1/encoder.rs#L449
[clippy] reported by reviewdog 🐶 error: use of a disallowed/placeholder name `e` --> actix-http/src/h1/encoder.rs:449:35 | 449 | .map_err(|e| io::Error::new(io::ErrorKind::Other, e))?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#disallowed_names = note: `-D clippy::disallowed-names` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::disallowed_names)]` Raw Output: actix-http/src/h1/encoder.rs:449:35:e:error: use of a disallowed/placeholder name `e` --> actix-http/src/h1/encoder.rs:449:35 | 449 | .map_err(|e| io::Error::new(io::ErrorKind::Other, e))?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#disallowed_names = note: `-D clippy::disallowed-names` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::disallowed_names)]` __END__
public-api-diff
Process completed with exit code 1.
fmt: actix-http/src/ws/codec.rs#L4
Diff in /home/runner/work/actix-web/actix-web/actix-http/src/ws/codec.rs
fmt: actix-http/src/ws/codec.rs#L12
Diff in /home/runner/work/actix-web/actix-web/actix-http/src/ws/codec.rs
fmt: actix-http/src/ws/frame.rs#L3
Diff in /home/runner/work/actix-web/actix-web/actix-http/src/ws/frame.rs
fmt: actix-http/src/ws/frame.rs#L11
Diff in /home/runner/work/actix-web/actix-web/actix-http/src/ws/frame.rs
clippy
The following actions use a deprecated Node.js version and will be forced to run on node20: giraffate/clippy-action@v1.0.1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/