Skip to content

Add support for permessage-deflate WebSocket extension #550

Add support for permessage-deflate WebSocket extension

Add support for permessage-deflate WebSocket extension #550

Triggered via pull request November 6, 2024 13:39
Status Failure
Total duration 1m 45s
Artifacts

lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

7 errors and 1 warning
clippy: actix-http/src/ws/deflate.rs#L587
[clippy] reported by reviewdog 🐶 error: this expression creates a reference which is immediately dereferenced by the compiler --> actix-http/src/ws/deflate.rs:587:61 | 587 | DeflateSessionParameters::from_extension_header(&extension), | ^^^^^^^^^^ help: change this to: `extension` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]` Raw Output: actix-http/src/ws/deflate.rs:587:61:e:error: this expression creates a reference which is immediately dereferenced by the compiler --> actix-http/src/ws/deflate.rs:587:61 | 587 | DeflateSessionParameters::from_extension_header(&extension), | ^^^^^^^^^^ help: change this to: `extension` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]` __END__
clippy: actix-http/src/ws/deflate.rs#L593
[clippy] reported by reviewdog 🐶 error: this expression creates a reference which is immediately dereferenced by the compiler --> actix-http/src/ws/deflate.rs:593:61 | 593 | DeflateSessionParameters::from_extension_header(&extension), | ^^^^^^^^^^ help: change this to: `extension` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow Raw Output: actix-http/src/ws/deflate.rs:593:61:e:error: this expression creates a reference which is immediately dereferenced by the compiler --> actix-http/src/ws/deflate.rs:593:61 | 593 | DeflateSessionParameters::from_extension_header(&extension), | ^^^^^^^^^^ help: change this to: `extension` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow __END__
clippy: actix-http/src/ws/deflate.rs#L599
[clippy] reported by reviewdog 🐶 error: this expression creates a reference which is immediately dereferenced by the compiler --> actix-http/src/ws/deflate.rs:599:61 | 599 | DeflateSessionParameters::from_extension_header(&extension), | ^^^^^^^^^^ help: change this to: `extension` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow Raw Output: actix-http/src/ws/deflate.rs:599:61:e:error: this expression creates a reference which is immediately dereferenced by the compiler --> actix-http/src/ws/deflate.rs:599:61 | 599 | DeflateSessionParameters::from_extension_header(&extension), | ^^^^^^^^^^ help: change this to: `extension` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow __END__
clippy: actix-http/src/ws/deflate.rs#L607
[clippy] reported by reviewdog 🐶 error: this expression creates a reference which is immediately dereferenced by the compiler --> actix-http/src/ws/deflate.rs:607:61 | 607 | DeflateSessionParameters::from_extension_header(&extension), | ^^^^^^^^^^ help: change this to: `extension` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow Raw Output: actix-http/src/ws/deflate.rs:607:61:e:error: this expression creates a reference which is immediately dereferenced by the compiler --> actix-http/src/ws/deflate.rs:607:61 | 607 | DeflateSessionParameters::from_extension_header(&extension), | ^^^^^^^^^^ help: change this to: `extension` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow __END__
clippy: actix-http/src/ws/deflate.rs#L613
[clippy] reported by reviewdog 🐶 error: this expression creates a reference which is immediately dereferenced by the compiler --> actix-http/src/ws/deflate.rs:613:61 | 613 | DeflateSessionParameters::from_extension_header(&extension), | ^^^^^^^^^^ help: change this to: `extension` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow Raw Output: actix-http/src/ws/deflate.rs:613:61:e:error: this expression creates a reference which is immediately dereferenced by the compiler --> actix-http/src/ws/deflate.rs:613:61 | 613 | DeflateSessionParameters::from_extension_header(&extension), | ^^^^^^^^^^ help: change this to: `extension` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow __END__
clippy: actix-http/src/ws/deflate.rs#L621
[clippy] reported by reviewdog 🐶 error: this expression creates a reference which is immediately dereferenced by the compiler --> actix-http/src/ws/deflate.rs:621:61 | 621 | DeflateSessionParameters::from_extension_header(&extension), | ^^^^^^^^^^ help: change this to: `extension` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow Raw Output: actix-http/src/ws/deflate.rs:621:61:e:error: this expression creates a reference which is immediately dereferenced by the compiler --> actix-http/src/ws/deflate.rs:621:61 | 621 | DeflateSessionParameters::from_extension_header(&extension), | ^^^^^^^^^^ help: change this to: `extension` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow __END__
public-api-diff
Process completed with exit code 1.
clippy
The following actions use a deprecated Node.js version and will be forced to run on node20: giraffate/clippy-action@v1.0.1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/