-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support add connection header thought header apis #3221
base: master
Are you sure you want to change the base?
feat: support add connection header thought header apis #3221
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as duplicate.
This comment was marked as duplicate.
thanks for running the pipeline, waiting for someone to review it |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
f34dd1a
to
e65c649
Compare
@asonix thanks for your review, can you review it again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind these changes. There's still the intermediate allocation of the AHashMap but it's probably small (number of headers in a request doesn't exceed 10 in most scenarios probably)
I think Rob still needs to look at this even if I approve it so 🤷
e65c649
to
1295ed5
Compare
1295ed5
to
3e23d4f
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
3e23d4f
to
83cae00
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
5a932df
to
368e89f
Compare
368e89f
to
123cd2e
Compare
123cd2e
to
a4ec013
Compare
a4ec013
to
a9cbfee
Compare
a9cbfee
to
45e84b7
Compare
45e84b7
to
e2b49e9
Compare
e2b49e9
to
a17945f
Compare
PR Type
Fix
PR Checklist
Documentation comments have been added / updated.Overview
resolves #3220