Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support add connection header thought header apis #3221

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonatansalemes
Copy link

@jonatansalemes jonatansalemes commented Dec 12, 2023

PR Type

Fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

resolves #3220

@kvzn

This comment was marked as resolved.

@fafhrd91

This comment was marked as resolved.

@jonatansalemes

This comment was marked as duplicate.

@jonatansalemes
Copy link
Author

thanks for running the pipeline, waiting for someone to review it

@jonatansalemes

This comment was marked as duplicate.

@jonatansalemes

This comment was marked as duplicate.

actix-http/src/h1/encoder.rs Outdated Show resolved Hide resolved
actix-http/src/h1/encoder.rs Outdated Show resolved Hide resolved
@jonatansalemes jonatansalemes force-pushed the feat/issue-3220-connection-header-precedence branch 3 times, most recently from f34dd1a to e65c649 Compare May 19, 2024 21:19
@jonatansalemes
Copy link
Author

@asonix thanks for your review, can you review it again?

Copy link
Contributor

@asonix asonix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind these changes. There's still the intermediate allocation of the AHashMap but it's probably small (number of headers in a request doesn't exceed 10 in most scenarios probably)

I think Rob still needs to look at this even if I approve it so 🤷

@jonatansalemes jonatansalemes force-pushed the feat/issue-3220-connection-header-precedence branch from e65c649 to 1295ed5 Compare May 20, 2024 23:20
@jonatansalemes jonatansalemes force-pushed the feat/issue-3220-connection-header-precedence branch from 1295ed5 to 3e23d4f Compare May 30, 2024 02:25
@jonatansalemes

This comment was marked as duplicate.

@jonatansalemes jonatansalemes force-pushed the feat/issue-3220-connection-header-precedence branch from 3e23d4f to 83cae00 Compare June 7, 2024 02:00
@jonatansalemes

This comment was marked as duplicate.

@robjtede robjtede added A-http project: actix-http B-semver-minor labels Jun 7, 2024
@bublikOff

This comment was marked as duplicate.

@robjtede robjtede self-requested a review June 10, 2024 07:18
@jonatansalemes jonatansalemes force-pushed the feat/issue-3220-connection-header-precedence branch 2 times, most recently from 5a932df to 368e89f Compare June 20, 2024 00:00
@jonatansalemes jonatansalemes force-pushed the feat/issue-3220-connection-header-precedence branch from 368e89f to 123cd2e Compare July 1, 2024 15:47
@jonatansalemes jonatansalemes force-pushed the feat/issue-3220-connection-header-precedence branch from 123cd2e to a4ec013 Compare July 13, 2024 22:04
@jonatansalemes jonatansalemes force-pushed the feat/issue-3220-connection-header-precedence branch from a4ec013 to a9cbfee Compare July 24, 2024 23:51
@jonatansalemes jonatansalemes force-pushed the feat/issue-3220-connection-header-precedence branch from a9cbfee to 45e84b7 Compare August 4, 2024 22:32
@jonatansalemes jonatansalemes force-pushed the feat/issue-3220-connection-header-precedence branch from 45e84b7 to e2b49e9 Compare August 18, 2024 00:13
@jonatansalemes jonatansalemes force-pushed the feat/issue-3220-connection-header-precedence branch from e2b49e9 to a17945f Compare September 18, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-http project: actix-http B-semver-minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pending multipart request with angular rxjs
6 participants