-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Minimal example for using C++20 concepts #2034
Conversation
The concept is intentionally wrong (takes a reference instead of a pointer) to showcase the error we (hopefully) get in the CI. |
Codecov Report
@@ Coverage Diff @@
## main #2034 +/- ##
=======================================
Coverage 49.85% 49.85%
=======================================
Files 421 421
Lines 23889 23889
Branches 10843 10843
=======================================
Hits 11911 11911
Misses 4357 4357
Partials 7621 7621
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for b305417Full report VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Ah didn't read the comment that it should fail |
It did fail, and then I fixed the concept, so now we indeed expect success. |
This adds a very simple
SurfaceVisitorConcept
to test the conditional implementation.