Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Minimal example for using C++20 concepts #2034

Merged
merged 8 commits into from
Apr 17, 2023

Conversation

paulgessinger
Copy link
Member

This adds a very simple SurfaceVisitorConcept to test the conditional implementation.

@paulgessinger paulgessinger added this to the next milestone Apr 17, 2023
@paulgessinger
Copy link
Member Author

The concept is intentionally wrong (takes a reference instead of a pointer) to showcase the error we (hopefully) get in the CI.

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #2034 (b305417) into main (da77587) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2034   +/-   ##
=======================================
  Coverage   49.85%   49.85%           
=======================================
  Files         421      421           
  Lines       23889    23889           
  Branches    10843    10843           
=======================================
  Hits        11911    11911           
  Misses       4357     4357           
  Partials     7621     7621           
Impacted Files Coverage Δ
Core/include/Acts/Geometry/TrackingGeometry.hpp 100.00% <ø> (ø)
Core/include/Acts/Geometry/TrackingVolume.hpp 70.73% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Apr 17, 2023

📊 Physics performance monitoring for b305417

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@benjaminhuth benjaminhuth added Component - Core Affects the Core module Infrastructure Changes to build tools, continous integration, ... automerge and removed Component - Core Affects the Core module Infrastructure Changes to build tools, continous integration, ... automerge labels Apr 17, 2023
@benjaminhuth
Copy link
Member

Ah didn't read the comment that it should fail

@paulgessinger
Copy link
Member Author

It did fail, and then I fixed the concept, so now we indeed expect success.

@kodiakhq kodiakhq bot merged commit be509fa into acts-project:main Apr 17, 2023
@paulgessinger paulgessinger modified the milestones: next, v25.0.0 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants