Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: re-template algebra #893

Merged
merged 1 commit into from
Dec 18, 2024
Merged

ref: re-template algebra #893

merged 1 commit into from
Dec 18, 2024

Conversation

niermann999
Copy link
Contributor

@niermann999 niermann999 commented Nov 29, 2024 •
edited
Loading

Remove the global scalar type and default ALGEBRA_PLUGIN macro and instead hand the templates type through everywhere

@niermann999 niermann999 force-pushed the ref-retemplate-algebra branch 2 times, most recently from 75c5afb to 451f651 Compare December 8, 2024 11:58
@niermann999 niermann999 added enhancement New feature or request refactor refactoring the current codes priority: medium medium priority labels Dec 8, 2024
@niermann999 niermann999 force-pushed the ref-retemplate-algebra branch 5 times, most recently from 61f4547 to f4bcbb5 Compare December 8, 2024 19:17
@niermann999 niermann999 force-pushed the ref-retemplate-algebra branch from f4bcbb5 to 061fcf8 Compare December 9, 2024 00:17
@niermann999 niermann999 mentioned this pull request Dec 9, 2024
Merged
@niermann999 niermann999 force-pushed the ref-retemplate-algebra branch from 061fcf8 to 2632541 Compare December 9, 2024 12:06
krasznaa
krasznaa reviewed Dec 9, 2024
View reviewed changes
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I of course didn't read all the changes (yet). Let's maybe agree on these first points before I go further. 🤔

core/include/detray/builders/bin_fillers.hpp Show resolved Hide resolved
core/include/detray/builders/cuboid_portal_generator.hpp Show resolved Hide resolved
core/include/detray/builders/cuboid_portal_generator.hpp Show resolved Hide resolved
core/include/detray/builders/cylinder_portal_generator.hpp Show resolved Hide resolved
@niermann999 niermann999 mentioned this pull request Dec 12, 2024
Open
@niermann999
Copy link
Contributor Author

Can we move forward with this?

beomki-yeo
beomki-yeo approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not read the full changes but let's not hold this up too long

@niermann999
Remove the global scalar type and default ALGEBRA_PLUGIN macro and in…
2645c44 
…stead hand the template type through everywhere
@niermann999 niermann999 force-pushed the ref-retemplate-algebra branch from 2632541 to 2645c44 Compare December 18, 2024 12:51
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
8 New issues
5 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.9% Duplication on New Code

See analysis details on SonarQube Cloud

@niermann999 niermann999 merged commit 93eb6ab into acts-project:main Dec 18, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krasznaa krasznaa krasznaa left review comments

@beomki-yeo beomki-yeo beomki-yeo approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request priority: medium medium priority refactor refactoring the current codes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niermann999 @krasznaa @beomki-yeo