Reenable FMA in CUDA builds #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
added
priority: medium
stephenswat
force-pushed
the
build/fma
branch
from
8e7ed12 to
8c89f8e
Compare
|
This might be controversial, but we're kneecapping the CUDA build by turning off FMA. I think it's high time to turn it back on. Also removes an inaccurate comment, as FMA doesn't have anything to do with fast math, as FMA is well specified in IEEE 754-2008.
niermann999
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be controversial, but we're kneecapping the CUDA build by turning off FMA. I think it's high time to turn it back on. Also removes an inaccurate comment, as FMA doesn't have anything to do with fast math; FMA is well specified in IEEE 754-2008.